Skip to content

ci(OMN-12736): harden migration freeze checkout timeout - #1882

Merged
jonahgabriel merged 1 commit into
devfrom
jonah/omn-12736-migration-freeze-checkout-hardening
Jun 7, 2026
Merged

jonahgabriel merged 1 commit into
devfrom
jonah/omn-12736-migration-freeze-checkout-hardening

Conversation

@jonahgabriel

@jonahgabriel jonahgabriel commented Jun 6, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • OMN-12736: harden the Migration Freeze Check merge_group path after run 27058639824 / job 79867549855 spent the full 5m budget in actions/checkout@v6 fetching gh-readonly-queue/dev/pr-1881 and skipped the freeze script.
  • Raise the migration-freeze job timeout from 5m to 15m.
  • Bound the checkout step at 10m, keep shallow fetch-depth: 2, and make fetch-tags: false explicit. The freeze script remains unchanged and required.
  • Extend focused CI workflow resilience coverage for the new timeout/fetch settings.

Verification

  • uv run pytest tests/ci/test_ci_workflow_resilience.py -q
  • uv run ruff format --check tests/ci/test_ci_workflow_resilience.py
  • uv run ruff check tests/ci/test_ci_workflow_resilience.py
  • git diff --check

Evidence

OMN-12736

Evidence-Source: OCC#2254

Evidence-Ticket: OMN-12736

This is a CI-only workflow-hardening change (.github/workflows + focused CI resilience test); it ships no runtime contract, node, handler, topic, or migration. The Evidence-Source above (OCC#2254, merged to OCC main at e3a7974c) carries the OMN-12736 contract; the Receipt Gate (OMN-10419) resolves the merged OCC PR to its merge commit on OCC main.

Notes

  • No merge or deploy performed.

Summary by CodeRabbit

  • Chores

    • Enhanced CI job timeout configurations and checkout behavior for improved stability.
  • Tests

    • Updated CI resilience test suite to validate timeout settings and checkout parameters.

@coderabbitai

coderabbitai Bot commented Jun 6, 2026 •

Copy link
Copy Markdown

PR changed again? Review this PR in Change Stack to compare snapshots and stay oriented.

Review Change Stack

📝 Walkthrough

Walkthrough

The PR hardens the migration-freeze CI job for merge_group runs by increasing its timeout to 15 minutes, adding a 10-minute timeout to the checkout step, and configuring checkout with shallow fetch (depth 2) while disabling tag fetching. Tests are updated to verify these new timeout and fetch constraints.

Changes

Migration-freeze job timeout and checkout bounds

Layer / File(s) Summary
Bounded migration-freeze job timeout and checkout
.github/workflows/ci.yml, tests/ci/test_ci_workflow_resilience.py
Job-level timeout increased and per-step checkout timeout added with restricted fetch options (depth 2, tags disabled). Test updated from shallow checkout validation to bounded-checkout assertions verifying job timeout, step timeout, and fetch configuration.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Poem

A rabbit hops through merge_group flows,
With bounded timeouts, the CI knows—
Fetch shallow, fetch swift, no tags to store,
The workflow's tighter than before! 🐇⏰

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title accurately summarizes the main change: hardening the migration freeze checkout timeout configuration with increased timeouts and stricter fetch settings.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch jonah/omn-12736-migration-freeze-checkout-hardening

Comment @coderabbitai help to get the list of available commands and usage tips.

@jonahgabriel jonahgabriel changed the title ci: harden migration freeze checkout timeout ci(OMN-12736): harden migration freeze checkout timeout Jun 7, 2026
@jonahgabriel
jonahgabriel added this pull request to the merge queue Jun 7, 2026
Merged via the queue into dev with commit fc5befd Jun 7, 2026
73 of 81 checks passed
@jonahgabriel
jonahgabriel deleted the jonah/omn-12736-migration-freeze-checkout-hardening branch June 7, 2026 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant