Repository navigation
fix(OMN-12734): clear contract resolver bifrost path - #1881
Conversation
|
Need an answer fast? Review this PR in Change Stack to ask focused questions about the PR or a changed range. 📝 WalkthroughWalkthroughThis PR sets ChangesBifrost contract path clearing
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Evidence-Source: OCC#2218
Evidence-Ticket: OMN-12734
Summary
BIFROST_CONTRACT_PATHforomninode-contract-resolverindocker-compose.infra.ymlso the service does not try to render Bifrost delegation config into/app/datawithout a data mount.catalog_env.Runtime impact
This preserves the live dev-lane hotpatch in durable infra sources. It changes only contract-resolver startup env by disabling Bifrost contract rendering for that no-data-volume HTTP bridge. No live restart was performed from this PR.
Verification
PYTHONPATH="$PWD/src:$PWD${PYTHONPATH:+:$PYTHONPATH}" uv run pytest tests/unit/infra/test_catalog_completeness.py tests/integration/test_runtime_sub_bundle_cli.py -qenv ... docker compose --env-file docker/runtime-policy.env -f docker/docker-compose.infra.yml --profile runtime config --format jsonomninode-contract-resolver.environment.BIFROST_CONTRACT_PATH == ""uv run ruff format tests/unit/infra/test_catalog_completeness.py tests/integration/test_runtime_sub_bundle_cli.pyuv run ruff check tests/unit/infra/test_catalog_completeness.py tests/integration/test_runtime_sub_bundle_cli.pygit diff --checkOCC Evidence
Post-merge validation
omninode-contract-resolverfrom the rendered deployed compose.http://127.0.0.1:8091/healthremains ok and the service no longer logs Bifrost delegation render failures.Linear: OMN-12734