Skip to content

fix(OMN-12724): flatten delegation terminal publish payload - #1878

Merged
jonahgabriel merged 3 commits into
devfrom
jonah/omn-12724-bug-dev-runtime-maineffects-both-consume-delegation-workflow
Jun 6, 2026
Merged

jonahgabriel merged 3 commits into
devfrom
jonah/omn-12724-bug-dev-runtime-maineffects-both-consume-delegation-workflow

Conversation

@jonahgabriel

@jonahgabriel jonahgabriel commented Jun 6, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • flatten topic-bearing delegation terminal envelopes before wrapping them in ModelEventEnvelope
  • preserve topic resolution from the outer event while publishing the inner terminal payload for projections
  • pass the selected runtime profile through typed ModelDomainPluginConfig during kernel bootstrap
  • add focused coverage for delegation terminal payload shape and plugin config runtime-profile propagation

Verification

  • uv run pytest tests/unit/runtime/test_kernel_wiring.py tests/unit/runtime/test_dispatch_result_applier_topic_routing.py -q (25 passed)
  • uv run ruff check src/omnibase_infra/runtime/models/model_domain_plugin_config.py src/omnibase_infra/runtime/service_kernel.py src/omnibase_infra/runtime/service_dispatch_result_applier.py tests/unit/runtime/test_kernel_wiring.py tests/unit/runtime/test_dispatch_result_applier_topic_routing.py
  • uv run ruff format --check src/omnibase_infra/runtime/models/model_domain_plugin_config.py src/omnibase_infra/runtime/service_kernel.py tests/unit/runtime/test_kernel_wiring.py

Runtime proof

Dev-lane delegation unit-test e2e correlation ead5475c-be5d-415c-a1ab-e526a0faf3d9 emitted a flattened delegation-completed payload with useful pytest content and quality_score=1.0.

Evidence-Source: OCC#2212
Evidence-Ticket: OMN-12724

@coderabbitai

coderabbitai Bot commented Jun 6, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

@jonahgabriel, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 7 minutes and 47 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: ac6c9785-0f10-4a45-b056-86cc1fdefa1f

📥 Commits

Reviewing files that changed from the base of the PR and between 8560104 and 6541997.

📒 Files selected for processing (10)
  • src/omnibase_infra/nodes/node_llm_inference_effect/contract.yaml
  • src/omnibase_infra/runtime/auto_wiring/profile_ownership.py
  • src/omnibase_infra/runtime/models/model_domain_plugin_config.py
  • src/omnibase_infra/runtime/runtime_host_process.py
  • src/omnibase_infra/runtime/service_dispatch_result_applier.py
  • src/omnibase_infra/runtime/service_kernel.py
  • tests/unit/runtime/auto_wiring/test_runtime_profile_ownership.py
  • tests/unit/runtime/test_dispatch_result_applier_topic_routing.py
  • tests/unit/runtime/test_kernel_wiring.py
  • tests/unit/runtime/test_node_subscription_wiring.py
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch jonah/omn-12724-bug-dev-runtime-maineffects-both-consume-delegation-workflow

Comment @coderabbitai help to get the list of available commands and usage tips.

@jonahgabriel
jonahgabriel enabled auto-merge June 6, 2026 04:25
@jonahgabriel
jonahgabriel added this pull request to the merge queue Jun 6, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jun 6, 2026
@jonahgabriel
jonahgabriel added this pull request to the merge queue Jun 6, 2026
Merged via the queue into dev with commit 2144328 Jun 6, 2026
75 of 76 checks passed
@jonahgabriel
jonahgabriel deleted the jonah/omn-12724-bug-dev-runtime-maineffects-both-consume-delegation-workflow branch June 6, 2026 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant