Skip to content

fix(OMN-12724): respect runtime profile ownership for subscriptions - #1874

Merged
jonahgabriel merged 1 commit into
devfrom
jonah/omn-12724-bug-dev-runtime-maineffects-both-consume-delegation-workflow
Jun 5, 2026
Merged

jonahgabriel merged 1 commit into
devfrom
jonah/omn-12724-bug-dev-runtime-maineffects-both-consume-delegation-workflow

Conversation

@jonahgabriel

@jonahgabriel jonahgabriel commented Jun 5, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • apply runtime profile ownership filtering to raw runtime-host subscription paths
  • mark node_llm_inference_effect as effects runtime-owned
  • add regression coverage proving effects skips main-owned delegation workflow topics and main skips effects-owned LLM inference topics

Live Failure Context

Observed during the 2026-06-05 dev-runtime delegation proof. Correlation b29b9532-df6a-45e4-8024-04461604d3cc completed useful pytest output, but emitted duplicate inference responses, duplicate quality results, and duplicate completed events because both omninode-runtime and omninode-runtime-effects consumed delegation workflow topics.

Verification

  • uv run pytest tests/unit/runtime/auto_wiring/test_runtime_profile_ownership.py tests/unit/runtime/test_node_subscription_wiring.py tests/unit/runtime/auto_wiring/test_wiring.py tests/unit/runtime/auto_wiring/test_wiring_subscribe.py tests/unit/runtime/auto_wiring/test_plugin_managed_subscription.py -q -> 88 passed
  • uv run ruff check src/omnibase_infra/runtime/auto_wiring/profile_ownership.py src/omnibase_infra/runtime/runtime_host_process.py tests/unit/runtime/auto_wiring/test_runtime_profile_ownership.py tests/unit/runtime/test_node_subscription_wiring.py -> passed

Refs OMN-12724

Evidence-Source: fa346609063f237721566746f2168c4890122091
Evidence-Ticket: OMN-12724

@coderabbitai

coderabbitai Bot commented Jun 5, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@jonahgabriel, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 45 minutes and 53 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 67056899-dbec-462d-adc2-af150c2328a6

📥 Commits

Reviewing files that changed from the base of the PR and between ee6f1ac and 617bf59.

📒 Files selected for processing (5)
  • src/omnibase_infra/nodes/node_llm_inference_effect/contract.yaml
  • src/omnibase_infra/runtime/auto_wiring/profile_ownership.py
  • src/omnibase_infra/runtime/runtime_host_process.py
  • tests/unit/runtime/auto_wiring/test_runtime_profile_ownership.py
  • tests/unit/runtime/test_node_subscription_wiring.py
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch jonah/omn-12724-bug-dev-runtime-maineffects-both-consume-delegation-workflow

Comment @coderabbitai help to get the list of available commands and usage tips.

@jonahgabriel

Copy link
Copy Markdown
Collaborator Author

Central OCC evidence for OMN-12724 is now in onex_change_control PR #2209: OmniNode-ai/onex_change_control#2209. This should unblock the Receipt Gate after OCC evidence merges and the downstream gate is rerun.

@jonahgabriel
jonahgabriel added this pull request to the merge queue Jun 5, 2026
Merged via the queue into dev with commit 187dcfc Jun 5, 2026
87 of 91 checks passed
@jonahgabriel
jonahgabriel deleted the jonah/omn-12724-bug-dev-runtime-maineffects-both-consume-delegation-workflow branch June 5, 2026 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant