Repository navigation
fix(OMN-12716): codify qwen vllm tool parser unit - #1871
Conversation
|
Warning Review limit reached
More reviews will be available in 110 minutes and 13 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis PR adds a systemd service unit to deploy vLLM as a managed service for the Qwen3.6-35B coder model on GPU 0 with OpenAI-compatible API, including tool-calling parser and auto-tool-choice support, along with regression-guard tests validating the service configuration. ChangesQwen Coder vLLM Service
🎯 2 (Simple) | ⏱️ ~8 minutes
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@tests/ci/test_vllm_qwen_coder_service_unit.py`:
- Around line 5-24: Add the missing pytest markers by importing pytest at the
top and decorating both test
functions—test_qwen_coder_vllm_unit_declares_tool_call_parser_flags and
test_qwen_coder_vllm_unit_preserves_stability_endpoint_identity—with
`@pytest.mark.unit` so they comply with the test-file marker requirement; ensure
the import statement (import pytest) is added if not already present.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 820b5db9-601e-4abd-97bb-54a389c2b3e8
📒 Files selected for processing (2)
deploy/systemd/vllm-gpu0-qwen-coder.servicetests/ci/test_vllm_qwen_coder_service_unit.py
Summary
--enable-auto-tool-choiceand--tool-call-parser qwen3_coderflagsEvidence
uv run ruff check tests/ci/test_vllm_qwen_coder_service_unit.py --fixuv run pytest tests/ci/test_vllm_qwen_coder_service_unit.py -q-> 2 passed--agentcorrelationf6859ca4-e2ad-46ea-bd14-4eaab5ae81f2returned PASS and{"is_healthy": true}39cba6ae-68d0-4690-8238-fcdda82f3890, modelQwen3.6-27B-MTP-IQ4_XS.gguf, contenthealthy=trueEvidence-Ticket: OMN-12716
Evidence-Source: OCC#2199