Skip to content

fix(OMN-12716): codify qwen vllm tool parser unit - #1871

Merged
jonahgabriel merged 2 commits into
devfrom
jonah/omn-12716-vllm-tool-parser-config
Jun 5, 2026
Merged

jonahgabriel merged 2 commits into
devfrom
jonah/omn-12716-vllm-tool-parser-config

Conversation

@jonahgabriel

@jonahgabriel jonahgabriel commented Jun 5, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • add a checked-in systemd unit for the .201 Qwen coder vLLM service
  • preserve the ADK-required --enable-auto-tool-choice and --tool-call-parser qwen3_coder flags
  • add a CI guard so the served model, port, context length, and tool parser flags do not drift

Evidence

  • uv run ruff check tests/ci/test_vllm_qwen_coder_service_unit.py --fix
  • uv run pytest tests/ci/test_vllm_qwen_coder_service_unit.py -q -> 2 passed
  • live hotpatch proof: SEA --agent correlation f6859ca4-e2ad-46ea-bd14-4eaab5ae81f2 returned PASS and {"is_healthy": true}
  • direct delegation proof: correlation 39cba6ae-68d0-4690-8238-fcdda82f3890, model Qwen3.6-27B-MTP-IQ4_XS.gguf, content healthy=true

Evidence-Ticket: OMN-12716
Evidence-Source: OCC#2199

@coderabbitai

coderabbitai Bot commented Jun 5, 2026 •

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@jonahgabriel, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 110 minutes and 13 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: fe685378-36cd-46c4-9fd5-de371b76886d

📥 Commits

Reviewing files that changed from the base of the PR and between 5d48bad and 308bdb2.

📒 Files selected for processing (1)
  • tests/ci/test_vllm_qwen_coder_service_unit.py
📝 Walkthrough

Walkthrough

This PR adds a systemd service unit to deploy vLLM as a managed service for the Qwen3.6-35B coder model on GPU 0 with OpenAI-compatible API, including tool-calling parser and auto-tool-choice support, along with regression-guard tests validating the service configuration.

Changes

Qwen Coder vLLM Service

Layer / File(s) Summary
vLLM systemd service configuration and validation tests
deploy/systemd/vllm-gpu0-qwen-coder.service, tests/ci/test_vllm_qwen_coder_service_unit.py
Systemd unit configures vLLM with GPU 0, Qwen3.6-35B model, port 8000, context length 131072, tool-call parser qwen3_coder, auto-tool-choice enabled, user jonah, CUDA device visibility, resource limits (MEMLOCK=infinity, NOFILE=65535), restart-on-failure with delay, and 600s startup timeout. Tests assert presence of tool-calling flags and stability endpoint parameters (port, model name, context length).

🎯 2 (Simple) | ⏱️ ~8 minutes

A rabbit springs forth with glee,
A service spawned, for Qwen to be,
Tools called by code, tests standing guard,
GPU zero works not too hard.
🐰✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title directly summarizes the main change: adding and testing a systemd unit file configuration for the Qwen vLLM tool parser service.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch jonah/omn-12716-vllm-tool-parser-config

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@tests/ci/test_vllm_qwen_coder_service_unit.py`:
- Around line 5-24: Add the missing pytest markers by importing pytest at the
top and decorating both test
functions—test_qwen_coder_vllm_unit_declares_tool_call_parser_flags and
test_qwen_coder_vllm_unit_preserves_stability_endpoint_identity—with
`@pytest.mark.unit` so they comply with the test-file marker requirement; ensure
the import statement (import pytest) is added if not already present.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 820b5db9-601e-4abd-97bb-54a389c2b3e8

📥 Commits

Reviewing files that changed from the base of the PR and between e62507f and 5d48bad.

📒 Files selected for processing (2)
  • deploy/systemd/vllm-gpu0-qwen-coder.service
  • tests/ci/test_vllm_qwen_coder_service_unit.py

Comment thread tests/ci/test_vllm_qwen_coder_service_unit.py
@jonahgabriel
jonahgabriel added this pull request to the merge queue Jun 5, 2026
Merged via the queue into dev with commit 068bf24 Jun 5, 2026
51 checks passed
@jonahgabriel
jonahgabriel deleted the jonah/omn-12716-vllm-tool-parser-config branch June 5, 2026 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant