[jonahgabriel]

Summary

Reverts #1859 (squash commit 73af6fa151295ef39fdc97265374eb8b797a12ce, merged to dev at 2026-06-04T03:40:13Z).

#1859 hardcoded a provider-specific full Gemini endpoint path
https://generativelanguage.googleapis.com/v1beta/openai/chat/completions
as the default_url in config_loader_bifrost.py, and added a URL-shape
predicate in handler_bifrost_gateway.py (routing "complete chat endpoint"
URLs through endpoint_url to skip the path append). That bakes one provider's
URL shape into the config loader and gateway, which is the provider-coupling we
do not want in the codebase.

This revert restores dev to its exact pre-#1859 state:

• config_loader_bifrost.py Gemini default_url returns to the provider-agnostic
  bare origin https://generativelanguage.googleapis.com (the value present in the
  parent commit d30f05d).
• handler_bifrost_gateway.py loses the /chat/completions//completions URL-shape
  predicate.
• The regression test file test_bifrost_endpoint_preservation.py is removed and the
  test_config_loader_bifrost.py additions are reverted.

The forward fix is a provider-agnostic, table-driven endpoint rewrite (tracked
under OMN-12664); it will replace #1859's approach without hardcoding any single
provider's path shape.

Cites OMN-12664.

dod_evidence

• Reverted merge commit: 73af6fa151295ef39fdc97265374eb8b797a12ce (squash, single parent d30f05d)
• Revert commit: 2be57777b22c8025da137a7a237e13194938d953
• Diff: 4 files changed, 3 insertions(+), 263 deletions(-) — exact inverse of fix(OMN-12664): preserve full Gemini endpoint path in bifrost gateway #1859
• Hardcoded path …/v1beta/openai/chat/completions confirmed gone from
  config_loader_bifrost.py (grep generativelanguage shows only the restored
  bare-origin default, which is pre-existing pre-fix(OMN-12664): preserve full Gemini endpoint path in bifrost gateway #1859 state).
• URL-shape predicate confirmed gone from handler_bifrost_gateway.py.
• uv run ruff format src/ tests/ — 4025 files unchanged (no reformat needed).
• uv run ruff check --fix on node_llm_inference_effect src + tests — All checks passed.
• uv run mypy --strict on config_loader_bifrost.py + handler_bifrost_gateway.py —
  Success: no issues found in 2 source files.
• uv run pytest tests/unit/nodes/node_llm_inference_effect/ — 455 passed.
• pre-commit run --files <changed> — all hooks Passed/Skipped, no failures.

Scope note: the full repo suite was not run (large); the node_llm_inference_effect +
bifrost unit tests (455) plus targeted mypy/ruff/pre-commit cover the reverted surface.

Deploy posture (OMN-10489)

This PR touches runtime handler paths under node_llm_inference_effect/handlers/bifrost/, so the deploy-gate applies. The deploy DoD evidence for the LLM endpoint_url runtime surface is owned by OMN-10489 (dod-deploy), the same deploy-evidence ticket the forward fix #1859 cited. This is a revert that restores the prior on-dev runtime state; no new deploy is performed by this PR (code + PR only, per session policy). The runtime redeploy of dev remains governed by OMN-10489.

Evidence-Source: OCC#2148

Evidence-Ticket: OMN-12664

[coderabbitai]

Warning

Review limit reached

@jonahgabriel, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 41 minutes and 8 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: fa5a2653-1681-4e79-8228-757bb6517c20

📥 Commits

Reviewing files that changed from the base of the PR and between c61ae0f and 2be5777.

📒 Files selected for processing (4)

• src/omnibase_infra/nodes/node_llm_inference_effect/handlers/bifrost/config_loader_bifrost.py
• src/omnibase_infra/nodes/node_llm_inference_effect/handlers/bifrost/handler_bifrost_gateway.py
• tests/unit/nodes/node_llm_inference_effect/handlers/bifrost/test_bifrost_endpoint_preservation.py
• tests/unit/nodes/node_llm_inference_effect/handlers/bifrost/test_config_loader_bifrost.py

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch jonah/omn-12664-revert-1859

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}