Repository navigation
ci(OMN-12535): harden sibling compat installs - #1815
jonahgabriel wants to merge 1 commit into
Conversation
|
Warning Review limit reached
More reviews will be available in 9 minutes and 33 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe workflow reinforces reliability by setting environment timeout and CPU-backend defaults, routes Python/uv setup through the established retrying action, and implements retry logic for the dry-run compatibility check. Regression tests validate both the setup routing and the transient-failure retry behavior. ChangesSibling Compatibility Workflow Resilience
Estimated Code Review Effort🎯 2 (Simple) | ⏱️ ~12 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
.github/workflows/check-sibling-compat.yml (1)
71-72: ⚡ Quick winConsider documenting the empty install-args.
The empty
install-args: ""intentionally suppresses the default uv sync behavior to allow custom installation logic later in the workflow. While this is working as intended, a brief inline comment would help future maintainers understand why the field is explicitly set to empty rather than omitted.📝 Suggested documentation
lock-file-path: 'omnibase_infra/**/uv.lock' working-directory: omnibase_infra + # Empty install-args suppresses default uv sync; custom dry-run install follows install-args: ""🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.github/workflows/check-sibling-compat.yml around lines 71 - 72, Add a brief inline comment next to the explicit empty setting install-args: "" explaining that the empty string intentionally suppresses the default uv sync/install behavior to allow custom installation logic later in the workflow; update the workflow entry containing install-args: "" so the comment succinctly states this intent for future maintainers (e.g., "install-args: \"\" # intentionally empty to disable default uv sync; custom install steps follow").
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In @.github/workflows/check-sibling-compat.yml:
- Around line 71-72: Add a brief inline comment next to the explicit empty
setting install-args: "" explaining that the empty string intentionally
suppresses the default uv sync/install behavior to allow custom installation
logic later in the workflow; update the workflow entry containing install-args:
"" so the comment succinctly states this intent for future maintainers (e.g.,
"install-args: \"\" # intentionally empty to disable default uv sync; custom
install steps follow").
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 0a891cf8-a9f8-4482-9b37-87495326ca5c
📒 Files selected for processing (2)
.github/workflows/check-sibling-compat.ymltests/ci/test_ci_workflow_resilience.py
|
Manual foreground tick: classified visible failures as setup/transport, not source assertions. Type Safety failed fetching onex_change_control from GitHub with GnuTLS termination; PEP 604 failed during uv dependency extraction for numpy after UV_HTTP_TIMEOUT=30s; CodeQL failed during checkout/fetch with GnuTLS/early EOF. Reran terminal parent workflows 26706652224, 26706652270, and 26706652279. |
|
Read-only sidecar triage follow-up (2026-05-31T17:16Z) Classified current terminal blockers as setup/transport/GitHub-platform; no source assertion and no unresolved review threads. Reran terminal candidates only:
Holding CI |
|
Foreground tick update for #1815:
I left CI parent |
4084a9f to
1236258
Compare
Pull request was converted to draft
|
Worker J merge-sweep triage: closing as superseded by current origin/dev.\n\nEvidence:\n- PR #1815 is based at 10a3b86 and conflicts with current origin/dev 82be452 in .github/workflows/check-sibling-compat.yml and tests/ci/test_ci_workflow_resilience.py.\n- origin/dev has bae87dc / #1823, ci(OMN-12563): temporarily disable sibling compat process. The current check-sibling-compat workflow is an emergency no-op gate and intentionally does not run checkout, Python setup, uv sync, or sibling install validation.\n- origin/dev tests now assert sibling-compat has no setup-python-uv usage and no uv sync / uv pip install lines, with OMN-12563 evidence in the gate.\n\nThe PR's retrying sibling dry-run install path is therefore no longer the active architecture; rebasing it would undo the OMN-12563 incident mitigation and add CI pressure. No push or undraft recommended. |
Summary
Verification
Linear: OMN-12535
Summary by CodeRabbit
Chores
Tests
Evidence-Source: OCC#1982
Evidence-Ticket: OMN-12535