Skip to content

ci(OMN-12535): harden sibling compat installs - #1815

Closed
jonahgabriel wants to merge 1 commit into
devfrom
jonah/omn-12535-harden-sibling-compat-ci-install-path-against-uv-download
Closed

jonahgabriel wants to merge 1 commit into
devfrom
jonah/omn-12535-harden-sibling-compat-ci-install-path-against-uv-download

Conversation

@jonahgabriel

@jonahgabriel jonahgabriel commented May 31, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • route Sibling Compat dependency install through the retrying setup-python-uv action
  • set long uv HTTP timeout and CPU torch backend at workflow level
  • retry the sibling dry-run install to survive transient dependency download timeouts

Verification

  • uv run pytest tests/ci/test_ci_workflow_resilience.py -q
  • uv run ruff format --check tests/ci/test_ci_workflow_resilience.py
  • uv run ruff check tests/ci/test_ci_workflow_resilience.py
  • git diff --check

Linear: OMN-12535

Summary by CodeRabbit

  • Chores

    • Enhanced CI workflow with improved retry mechanisms for dependency compatibility checks, increasing reliability when encountering transient issues.
  • Tests

    • Added regression tests to verify CI workflow resilience and error handling capabilities.

Evidence-Source: OCC#1982
Evidence-Ticket: OMN-12535

@coderabbitai

coderabbitai Bot commented May 31, 2026 •

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@jonahgabriel, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 9 minutes and 33 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: a988ac11-2cfd-4774-8ebc-97a1751bf603

📥 Commits

Reviewing files that changed from the base of the PR and between 4084a9f and 1236258.

📒 Files selected for processing (2)
  • .github/workflows/check-sibling-compat.yml
  • tests/ci/test_ci_workflow_resilience.py
📝 Walkthrough

Walkthrough

The workflow reinforces reliability by setting environment timeout and CPU-backend defaults, routes Python/uv setup through the established retrying action, and implements retry logic for the dry-run compatibility check. Regression tests validate both the setup routing and the transient-failure retry behavior.

Changes

Sibling Compatibility Workflow Resilience

Layer / File(s) Summary
Workflow environment and setup configuration
.github/workflows/check-sibling-compat.yml
UV_HTTP_TIMEOUT (600s) and UV_TORCH_BACKEND (cpu) environment variables are added at the workflow level. The "Setup Python and uv" action inputs are updated to set working-directory: omnibase_infra and install-args: "", eliminating the separate dev-dependency install step.
Dry-run retry mechanism
.github/workflows/check-sibling-compat.yml
The uv pip install --dry-run command is wrapped in a bash retry loop that attempts execution up to 5 times with 10-second sleep intervals between failures. Warnings are logged on transient failures, and an error is raised if all attempts are exhausted.
Resilience regression tests
tests/ci/test_ci_workflow_resilience.py
A new CHECK_SIBLING_COMPAT_WORKFLOW path constant is introduced and used to load the workflow YAML. Two regression tests are added: one verifies that UV synchronization is routed through the retrying setup-python-uv action (and that direct installation/uv-sync steps are absent), and another verifies the OMN-4315 validation step's script includes retry control flow (max_attempts=5, until uv pip install ... loop) and warning/error formatting.

Estimated Code Review Effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Poem

🐰 A rabbit hops through timeout lands,
Setting UV_TORCH_BACKEND with careful hands,
Five retries dance in loops of sleep,
While tests keep watch, their vigil deep—
Resilience blooms where downloads creep! 🌱

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title directly references the main objective: hardening sibling compat installs by adding retry logic and timeout configuration.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch jonah/omn-12535-harden-sibling-compat-ci-install-path-against-uv-download

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
.github/workflows/check-sibling-compat.yml (1)

71-72: ⚡ Quick win

Consider documenting the empty install-args.

The empty install-args: "" intentionally suppresses the default uv sync behavior to allow custom installation logic later in the workflow. While this is working as intended, a brief inline comment would help future maintainers understand why the field is explicitly set to empty rather than omitted.

📝 Suggested documentation
       lock-file-path: 'omnibase_infra/**/uv.lock'
       working-directory: omnibase_infra
+      # Empty install-args suppresses default uv sync; custom dry-run install follows
       install-args: ""
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.github/workflows/check-sibling-compat.yml around lines 71 - 72, Add a brief
inline comment next to the explicit empty setting install-args: "" explaining
that the empty string intentionally suppresses the default uv sync/install
behavior to allow custom installation logic later in the workflow; update the
workflow entry containing install-args: "" so the comment succinctly states this
intent for future maintainers (e.g., "install-args: \"\"  # intentionally empty
to disable default uv sync; custom install steps follow").
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In @.github/workflows/check-sibling-compat.yml:
- Around line 71-72: Add a brief inline comment next to the explicit empty
setting install-args: "" explaining that the empty string intentionally
suppresses the default uv sync/install behavior to allow custom installation
logic later in the workflow; update the workflow entry containing install-args:
"" so the comment succinctly states this intent for future maintainers (e.g.,
"install-args: \"\"  # intentionally empty to disable default uv sync; custom
install steps follow").

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 0a891cf8-a9f8-4482-9b37-87495326ca5c

📥 Commits

Reviewing files that changed from the base of the PR and between 3fcb11f and 4084a9f.

📒 Files selected for processing (2)
  • .github/workflows/check-sibling-compat.yml
  • tests/ci/test_ci_workflow_resilience.py

@jonahgabriel

Copy link
Copy Markdown
Collaborator Author

Manual foreground tick: classified visible failures as setup/transport, not source assertions. Type Safety failed fetching onex_change_control from GitHub with GnuTLS termination; PEP 604 failed during uv dependency extraction for numpy after UV_HTTP_TIMEOUT=30s; CodeQL failed during checkout/fetch with GnuTLS/early EOF. Reran terminal parent workflows 26706652224, 26706652270, and 26706652279.

@jonahgabriel

Copy link
Copy Markdown
Collaborator Author

Read-only sidecar triage follow-up (2026-05-31T17:16Z)

Classified current terminal blockers as setup/transport/GitHub-platform; no source assertion and no unresolved review threads. Reran terminal candidates only:

  • 26706652270 Security Scan: CodeQL malformed/GnuTLS annotations.
  • 26706652219 Artifact Reconciliation Webhook: cancelled.
  • 26706652301 Deploy Gate: cancelled.

Holding CI 26706652279 and Standards 26706652224 because they are still queued/in progress.

@jonahgabriel

Copy link
Copy Markdown
Collaborator Author

Foreground tick update for #1815:

  • Standards parent 26706652224 attempt 3 is terminal failure.
  • Failed Type Safety / PEP604 jobs are setup/transport, not source: logs show uv sync --no-cache --all-extras failing to fetch omnibase_spi and onex_change_control via git with GnuTLS/TLS termination errors.
  • Reran failed jobs for terminal Standards parent 26706652224.

I left CI parent 26706652279, webhook 26706652219, CodeQL 26706652270, and Deploy Gate 26706652301 alone because they remain non-terminal/queued.

@jonahgabriel
jonahgabriel enabled auto-merge May 31, 2026 18:57
@jonahgabriel
jonahgabriel force-pushed the jonah/omn-12535-harden-sibling-compat-ci-install-path-against-uv-download branch from 4084a9f to 1236258 Compare June 1, 2026 01:10
@jonahgabriel
jonahgabriel marked this pull request as draft June 1, 2026 04:08
auto-merge was automatically disabled June 1, 2026 04:08

Pull request was converted to draft

@jonahgabriel

Copy link
Copy Markdown
Collaborator Author

Worker J merge-sweep triage: closing as superseded by current origin/dev.\n\nEvidence:\n- PR #1815 is based at 10a3b86 and conflicts with current origin/dev 82be452 in .github/workflows/check-sibling-compat.yml and tests/ci/test_ci_workflow_resilience.py.\n- origin/dev has bae87dc / #1823, ci(OMN-12563): temporarily disable sibling compat process. The current check-sibling-compat workflow is an emergency no-op gate and intentionally does not run checkout, Python setup, uv sync, or sibling install validation.\n- origin/dev tests now assert sibling-compat has no setup-python-uv usage and no uv sync / uv pip install lines, with OMN-12563 evidence in the gate.\n\nThe PR's retrying sibling dry-run install path is therefore no longer the active architecture; rebasing it would undo the OMN-12563 incident mitigation and add CI pressure. No push or undraft recommended.

@jonahgabriel
jonahgabriel deleted the jonah/omn-12535-harden-sibling-compat-ci-install-path-against-uv-download branch June 11, 2026 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant