Skip to content

fix(OMN-11068): fail healthcheck for degraded runtime - #1608

Closed
jonahgabriel wants to merge 2 commits into
mainfrom
jonah/omn-11068-healthcheck-degraded-runtime
Closed

jonahgabriel wants to merge 2 commits into
mainfrom
jonah/omn-11068-healthcheck-degraded-runtime

Conversation

@jonahgabriel

@jonahgabriel jonahgabriel commented May 15, 2026 •

Copy link
Copy Markdown
Collaborator

Evidence-Ticket: OMN-11068
Evidence-Source: OCC#1042

Summary

  • Return HTTP 503 from /health while RuntimeHostProcess is not attached (runtime_attached=false, startup_phase=runtime_pending).
  • Return HTTP 503 when an attached runtime reports is_running=false, while preserving HTTP 200 for degraded-but-running handler failures.
  • Add stability-test compose coverage proving runtime services inherit curl -sf http://localhost:8085/health, so Docker health fails on the 503 path.
  • Add repo-local deploy-gate contract evidence for OMN-11068.

Verification

  • uv run pytest tests/unit/runtime/test_service_health.py tests/integration/test_omn_9741_health_liveness.py tests/unit/infra/test_stability_test_runtime_lane.py tests/integration/infra/test_stability_test_runtime_compose_render.py -q
  • uv run ruff check src/omnibase_infra/runtime/service_runtime_host_process.py src/omnibase_infra/services/service_health.py tests/unit/runtime/test_service_health.py tests/integration/test_omn_9741_health_liveness.py tests/unit/infra/test_stability_test_runtime_lane.py tests/integration/infra/test_stability_test_runtime_compose_render.py
  • uv run python - <<'PY' ... contract YAML parse for contracts/OMN-11068.yaml
  • Commit hooks passed.
  • Pre-push hooks passed.

OCC Evidence

Deploy / Runtime Note

No deploy, restart, or mutation of .201 performed. Runtime validation should happen after merge through the normal deploy gate.

@coderabbitai

coderabbitai Bot commented May 15, 2026 •

Copy link
Copy Markdown

Warning

Rate limit exceeded

@jonahgabriel has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 10 minutes and 34 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: be16ffc4-9174-4891-ad45-1781d9ff0311

📥 Commits

Reviewing files that changed from the base of the PR and between 16e2587 and 4019008.

📒 Files selected for processing (9)
  • contracts/OMN-11068.yaml
  • docker/Dockerfile.runtime
  • docker/docker-compose.infra.yml
  • src/omnibase_infra/runtime/service_runtime_host_process.py
  • src/omnibase_infra/services/service_health.py
  • tests/integration/infra/test_stability_test_runtime_compose_render.py
  • tests/integration/test_omn_9741_health_liveness.py
  • tests/unit/infra/test_stability_test_runtime_lane.py
  • tests/unit/runtime/test_service_health.py
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch jonah/omn-11068-healthcheck-degraded-runtime

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud

Copy link
Copy Markdown

@jonahgabriel

Copy link
Copy Markdown
Collaborator Author

Closing stale salvage PR. Has merge conflicts with main and stale upstream pins (omnibase_core SHA force-deleted) blocking local pre-commit. The healthcheck behavior is being addressed in the broader runtime hardening track. Reopen or supersede with a fresh branch if needed.

@jonahgabriel
jonahgabriel deleted the jonah/omn-11068-healthcheck-degraded-runtime branch June 11, 2026 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant