Repository navigation
feat(OMN-10951): add delegation projection consumer to runtime-observability bundle - #1593
Conversation
…rvability-projections bundle The delegation projection consumer was defined in the service catalog but never added to a bundle. It consumes delegation events from Kafka and writes them to the omnidash_analytics.delegation_events Postgres table.
📝 WalkthroughWalkthroughA single service ( ChangesRuntime Observability Bundle Configuration
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
docker/catalog/bundles.yaml (1)
54-59:⚠️ Potential issue | 🟠 Major | ⚡ Quick winMissing analytics DB required env for the newly added delegation consumer.
omnimarket-projection-delegationis now part ofruntime-observability-projections, but this bundle doesn’t requireOMNIDASH_ANALYTICS_DB_URL. Given this consumer writes toomnidash_analytics.delegation_events, this can deploy a misconfigured service inonex up runtime.Suggested fix
runtime-observability-projections: description: "Runtime projection/observability consumers — postgres projections, cost aggregation, health projection, decision store (OMN-9332)" services: - injection-effectiveness-consumer - savings-estimation-consumer - llm-cost-aggregation-consumer - consumer-health-projection - decision-store-consumer - omnimarket-projection-delegation includes: [] inject_env: {} inject_required_env: - OMNIBASE_INFRA_INJECTION_EFFECTIVENESS_POSTGRES_DSN + - OMNIDASH_ANALYTICS_DB_URL🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@docker/catalog/bundles.yaml` around lines 54 - 59, The bundle declaration for runtime-observability-projections was updated to include omnimarket-projection-delegation but did not add the analytics DB env; update the bundle's inject_required_env list to include OMNIDASH_ANALYTICS_DB_URL so the consumer can write to omnidash_analytics.delegation_events. Locate the runtime-observability-projections bundle entry (the includes/inject_required_env block that references omnimarket-projection-delegation) and add OMNIDASH_ANALYTICS_DB_URL to inject_required_env alongside OMNIBASE_INFRA_INJECTION_EFFECTIVENESS_POSTGRES_DSN.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@docker/catalog/bundles.yaml`:
- Around line 54-59: The bundle declaration for
runtime-observability-projections was updated to include
omnimarket-projection-delegation but did not add the analytics DB env; update
the bundle's inject_required_env list to include OMNIDASH_ANALYTICS_DB_URL so
the consumer can write to omnidash_analytics.delegation_events. Locate the
runtime-observability-projections bundle entry (the includes/inject_required_env
block that references omnimarket-projection-delegation) and add
OMNIDASH_ANALYTICS_DB_URL to inject_required_env alongside
OMNIBASE_INFRA_INJECTION_EFFECTIVENESS_POSTGRES_DSN.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: c4baf9f8-ff7a-480a-a7ea-b9410535c74e
📒 Files selected for processing (1)
docker/catalog/bundles.yaml
|



Summary
omnimarket-projection-delegationto theruntime-observability-projectionsbundledocker/catalog/services/omnimarket-projection-delegation.yamlbut never added to a bundle, so it was never deployedTicket: OMN-10951
Epic: OMN-10939
What this enables
After merge +
onex up runtime, the delegation projection consumer will start alongside other projection consumers. It reads fromonex.evt.omniclaude.task-delegated.v1Kafka topic and writes toomnidash_analytics.delegation_eventsPostgres table.Test plan
uv run python -m omnibase_infra.docker.catalog.cli validate runtime-observability-projectionspassesrpk group listdelegation_eventstableSummary by CodeRabbit
Release Notes
Evidence-Source: OCC#1007
Evidence-Ticket: OMN-10951