feat(OMN-10769): pure condition evaluator for interactive onboarding transitions

[jonahgabriel]

Summary

• Adds evaluate_condition(expr, state) supporting ==, in [literal], in state_key, not in, and compound and
• None condition returns True; unknown state keys raise ConditionEvaluationError (strict, no silent fallback)
• Uses object throughout — no Any in function signatures or generic containers
• Covers all condition patterns used in interactive_onboarding.yaml
• Bumps INFRA_MAX_UNIONS from 148→149 for the list[object] | str collection return type

Ticket

OMN-10769 (child of OMN-10767 Interactive Onboarding Executor epic)

Test plan

• uv run pytest tests/unit/onboarding/test_condition_evaluator.py -v — 10/10 pass
• All pre-commit hooks pass (union, any-type, pattern, SPDX, ruff)
• uv run mypy src/omnibase_infra/onboarding/condition_evaluator.py --strict — clean

Summary by CodeRabbit

• Tests

  • Expanded test coverage for condition evaluation including membership operators and error handling scenarios.
  • Added integration tests validating routing decisions based on policy conditions in onboarding workflows.

• Chores

  • Added license header documentation.

Evidence-Source: 498cf95027d9d5661ee119de10575bd9fc55e392
Evidence-Ticket: OMN-10769

[coderabbitai]

📝 Walkthrough

Walkthrough

This PR adds comprehensive unit and integration test coverage for the onboarding condition evaluator. Unit tests extend membership operator checks with literal list support and state-based compound conditions; integration tests verify routing through an interactive onboarding policy using condition evaluation against dynamic state.

Changes

Condition Evaluator Test Coverage Expansion

Layer / File(s)	Summary
Unit Test Module Documentation tests/unit/onboarding/test_condition_evaluator.py	Module docstring updated to reference additional issue identifier.
Unit Test - Not In Literal Lists tests/unit/onboarding/test_condition_evaluator.py	TestNotIn class gains two test methods validating not in operator against literal list values, covering both non-membership (true) and membership (false) cases.
Unit Test - Interactive Onboarding Conditions tests/unit/onboarding/test_condition_evaluator.py	TestInteractiveOnboardingConditions class introduces tests for compound state-based conditions combining equality checks with service not in selected_local_services membership and item in response list membership that resolve against evaluator state.
Unit Test - Error Handling tests/unit/onboarding/test_condition_evaluator.py	TestUnknownKeyErrors adds error assertion verifying that unknown state keys used on the left-hand side of membership expressions raise ConditionEvaluationError with the missing key name.
Integration Test Infrastructure tests/integration/onboarding/__init__.py, tests/integration/onboarding/test_condition_evaluator_policy_integration.py	New integration test module with SPDX license header, imports, POLICY_PATH pointing to interactive_onboarding.yaml, and interactive_policy fixture that loads the YAML policy file.
Integration Test Helpers tests/integration/onboarding/test_condition_evaluator_policy_integration.py	Helper functions _transition_from and _next_on_submit_step enable navigation through policy transitions by matching step ids and evaluating condition branches against test state.
Integration Test Cases tests/integration/onboarding/test_condition_evaluator_policy_integration.py	Two integration tests verify routing behavior: local mode without LLM routes to write_config_local; hybrid mode without LLM routes to write_config_hybrid based on state shape and condition evaluation.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 New tests blossom like spring clover,
Membership checks and conditions all over,
State flows through branches, routing takes flight,
Integration and units—the coverage shines bright!
Hops forward with each assertion, pure delight! 🌱✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 21.05% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately reflects the main change: adding a pure condition evaluator for interactive onboarding transitions, which aligns with the PR objectives and file modifications.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch omn-10769-condition-evaluator

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@tests/unit/onboarding/test_condition_evaluator.py`:
- Around line 98-106: The test named test_not_in_literal_list is using the wrong
operator string ("in") so it never exercises the `not in` code path; update the
test's expression passed to evaluate_condition to use "not in" (for example
"deployment_mode not in [local, hybrid]") so evaluate_condition is invoked with
a `not in` operator and the assertion remains that the result is False; locate
this change in the test function test_not_in_literal_list in
tests/unit/onboarding/test_condition_evaluator.py which calls
evaluate_condition.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 6c6edacb-87e2-4ad5-b426-58d2946c2b17

📥 Commits

Reviewing files that changed from the base of the PR and between 0b7694c and 0bfe701.

📒 Files selected for processing (3)

• src/omnibase_infra/onboarding/condition_evaluator.py
• src/omnibase_infra/validation/infra_validators.py
• tests/unit/onboarding/test_condition_evaluator.py

[coderabbitai]

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

tests/integration/onboarding/test_condition_evaluator_policy_integration.py (1)

46-68: ⚠️ Potential issue | 🟠 Major | ⚡ Quick win

Add required integration test marker(s).

These tests are missing pytest markers. In this repo, tests must be explicitly marked; otherwise marker-based runs can skip them unintentionally. Please add @pytest.mark.integration on each test or set module-level pytestmark.

Suggested patch

 import pytest
 import yaml
 
 from omnibase_infra.onboarding.condition_evaluator import evaluate_condition
 
+pytestmark = pytest.mark.integration
+
 POLICY_PATH = (

As per coding guidelines: "Test files must use pytest markers: mark test functions with @pytest.mark.unit, @pytest.mark.integration, @pytest.mark.slow, @pytest.mark.chaos, or @pytest.mark.performance as appropriate".

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@tests/integration/onboarding/test_condition_evaluator_policy_integration.py`
around lines 46 - 68, The two integration tests
(test_policy_not_in_response_routes_local_without_llm_to_terminal and
test_policy_not_in_selected_services_routes_hybrid_without_llm_to_terminal) are
missing pytest markers; add `@pytest.mark.integration` above each test function or
define a module-level pytestmark = [pytest.mark.integration] to ensure pytest
recognizes them as integration tests, and import pytest at top if not already
present; keep the existing test names and assertions unchanged.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Outside diff comments:
In `@tests/integration/onboarding/test_condition_evaluator_policy_integration.py`:
- Around line 46-68: The two integration tests
(test_policy_not_in_response_routes_local_without_llm_to_terminal and
test_policy_not_in_selected_services_routes_hybrid_without_llm_to_terminal) are
missing pytest markers; add `@pytest.mark.integration` above each test function or
define a module-level pytestmark = [pytest.mark.integration] to ensure pytest
recognizes them as integration tests, and import pytest at top if not already
present; keep the existing test names and assertions unchanged.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 99d4c604-bcb3-444a-90a5-c30e550d6a02

📥 Commits

Reviewing files that changed from the base of the PR and between 0bfe701 and a5b8b05.

📒 Files selected for processing (3)

• tests/integration/onboarding/__init__.py
• tests/integration/onboarding/test_condition_evaluator_policy_integration.py
• tests/unit/onboarding/test_condition_evaluator.py

✅ Files skipped from review due to trivial changes (2)

• tests/integration/onboarding/init.py
• tests/unit/onboarding/test_condition_evaluator.py