Skip to content

feat(observability): wire Phoenix OTLP tracing for local LLM routes [OMN-8697] #1289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jonahgabriel merged 2 commits into from
Apr 14, 2026
Merged

feat(observability): wire Phoenix OTLP tracing for local LLM routes [OMN-8697] #1289

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3a26bfe
feat(observability): wire Phoenix OTLP tracing for local LLM routes […
jonahgabriel Apr 14, 2026
b311443
fix(observability): guard token count cast with isinstance to satisfy…
jonahgabriel Apr 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docker/catalog/bundles.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ runtime:
- autoheal
includes:
- core
- tracing # OMN-8697: always wire Phoenix OTLP tracing with the runtime
observability:
description: "LLM observability — Phoenix traces and evals"
services:
Expand Down
8 changes: 5 additions & 3 deletions docker/docker-compose.infra.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,9 +211,11 @@ x-runtime-env: &runtime-env
LLM_CODER_FAST_URL: ${LLM_CODER_FAST_URL:?LLM_CODER_FAST_URL required for PluginLlm activation}
LLM_EMBEDDING_URL: ${LLM_EMBEDDING_URL:?LLM_EMBEDDING_URL required for PluginLlm activation}
LLM_DEEPSEEK_R1_URL: ${LLM_DEEPSEEK_R1_URL:?LLM_DEEPSEEK_R1_URL required for PluginLlm activation}
# --- OpenTelemetry (OMN-5382: removed from base env — injected per-bundle) ---
# OTEL vars are only present when the tracing bundle is selected.
# OTEL_SERVICE_NAME is set per-service (already done in service blocks).
# --- OpenTelemetry (OMN-8697: wired to Phoenix for LLM span visibility) ---
# Phoenix runs alongside the runtime; all containers export spans via OTLP HTTP.
# OTEL_SERVICE_NAME is set per-service (see individual service blocks below).
OTEL_EXPORTER_OTLP_ENDPOINT: "http://phoenix:6006"
OTEL_TRACES_EXPORTER: "otlp"
Comment on lines +214 to +218

@coderabbitai coderabbitai Bot Apr 14, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

x-runtime-env only covers a subset of the runtime profile.

agent-actions-consumer, skill-lifecycle-consumer, context-audit-consumer, and intelligence-api do not inherit *runtime-env, so they will not see these OTEL vars under local compose. That makes the Line 215 comment inaccurate today, and it also means local compose tracing can diverge from bundle-based runtime deployments if any of those entrypoints initialize tracing.
Based on learnings, "ensure any comments/docs about env-var behavior match the real activation logic."

🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@docker/docker-compose.infra.yml` around lines 214 - 218, The comment and
x-runtime-env don't cover all runtime services: add the OTEL vars to the service
blocks that currently omit x-runtime-env (agent-actions-consumer,
skill-lifecycle-consumer, context-audit-consumer, intelligence-api) or refactor
those service stanzas to inherit x-runtime-env so OTEL_EXPORTER_OTLP_ENDPOINT
and OTEL_TRACES_EXPORTER are present for local compose; update the service
definitions (agent-actions-consumer, skill-lifecycle-consumer,
context-audit-consumer, intelligence-api) to include the OTEL env vars or
reference x-runtime-env to ensure local tracing parity with bundle-based
deployments.

# ==========================================================================
# Services
# ==========================================================================
Expand Down
Loading
Loading