fix(omnibase_infra): eliminate HARDCODED_TOPIC + UNDECLARED_TRANSPORT violations [OMN-8605]

[jonahgabriel]

Summary

• Replaced all hardcoded Kafka topic string literals in 9 non-test source files with references to canonical suffix constants from platform_topic_suffixes.py and EnumPlatformTopic
• Added 8 new suffix constants to platform_topic_suffixes.py for topics that were missing: SUFFIX_LINEAR_SNAPSHOT, SUFFIX_GIT_HOOK, and 6 omniclaude injection-effectiveness topics
• All pre-commit hooks pass including No hardcoded ONEX topic strings gate

Files changed

• runtime/contract_registration_event_router.py — 3 module-level constants
• tui/consumers/consumer_status.py — 3 module-level constants
• cli/linear_relay.py, cli/git_hook_relay.py — 1 constant each
• services/service_timeout_emitter.py — 2 class defaults via EnumPlatformTopic
• services/observability/agent_actions/consumer.py — 14 dict key strings
• services/observability/injection_effectiveness/config.py — 6 topic strings in default_factory
• services/observability/llm_cost_aggregation/config.py — 1 topic string

Test plan

• Pre-commit hooks pass (all 44 checks green, No hardcoded ONEX topic strings explicitly passed)
• ruff format + ruff check clean
• mypy passes (confirmed via push hook)

Summary by CodeRabbit

• Refactor

  • Consolidated event topic definitions into centralized platform constants for improved consistency across the system.

• Tests

  • Added integration tests to validate event topic compliance and constant exports.

[coderabbitai]

Caution

Review failed

Pull request was closed or merged during review

📝 Walkthrough

Walkthrough

This pull request centralizes Kafka topic suffix constants by introducing 8 new shared constants in a dedicated module and updating 8 modules to import these constants instead of using hardcoded topic strings. Integration tests validate the new exports and topic compliance.

Changes

Cohort / File(s)	Summary
Core Topic Constants src/omnibase_infra/topics/platform_topic_suffixes.py, src/omnibase_infra/topics/__init__.py	Added 8 new topic suffix constants (SUFFIX_GIT_HOOK, SUFFIX_LINEAR_SNAPSHOT, and 6 OmniClaude-related suffixes) and exported them from the topics package.
Relay and Router Modules src/omnibase_infra/cli/git_hook_relay.py, src/omnibase_infra/cli/linear_relay.py, src/omnibase_infra/runtime/contract_registration_event_router.py	Replaced hardcoded topic strings with imported SUFFIX_* constants for topic definition and routing logic.
Observability Consumer Modules src/omnibase_infra/services/observability/agent_actions/consumer.py, src/omnibase_infra/services/observability/injection_effectiveness/config.py, src/omnibase_infra/services/observability/llm_cost_aggregation/config.py	Updated TOPIC_TO_MODEL mappings and default topic configurations to use imported suffix constants instead of hardcoded ONEX topic strings.
Service Emission and Status Monitoring src/omnibase_infra/services/service_timeout_emitter.py, src/omnibase_infra/tui/consumers/consumer_status.py	Updated DEFAULT_*_TOPIC and module-level topic constants to reference imported suffix constants or EnumPlatformTopic enum values.
Integration Tests tests/integration/registration/test_topic_suffix_compliance.py, tests/integration/test_topic_suffix_exports.py	Added compliance tests validating new suffix constant exports, canonical string values, and topic suffix conformance across the platform.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

• feat(OMN-1547): Replace hardcoded topics with validated suffix constants #206: Refactors hardcoded Kafka topic strings to use shared SUFFIX_* constants across multiple modules and updates omnibase_infra.topics exports.
• feat(OMN-2310): Topic Catalog model + suffix foundation #357: Adds new SUFFIX_* constants to platform_topic_suffixes and updates omnibase_infra.topics package exports.
• feat(OMN-1972): Add canonical TopicResolver and declarative orchestrator subscriptions #253: Modifies canonical ONEX topic handling by introducing a TopicResolver and updating platform-prefixed topic usage alongside omnibase_infra.topics exports.

Poem

🐰 Constants hop together now, no strings astray,
A single source of truth to light the way,
From git hooks to omniclaude's gentle call,
Centralized suffixes unify them all! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 14.29% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The PR title accurately reflects the main change: replacing hardcoded Kafka topic literals with canonical suffix constants to resolve linting violations.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch jonah/omn-8605-compliance-omnibase_infra

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}