Repository navigation
feat(runtime): enable RuntimeLogEventBridge via feature flag [OMN-6972] - #1228
Merged
jonahgabriel merged 1 commit intoApr 11, 2026
Merged
Conversation
…IDGE=true [OMN-6972] The RuntimeLogEventBridge emitter (OMN-5521) and HandlerRuntimeErrorTriage consumer (OMN-5525) have been on main for weeks, but ENABLE_RUNTIME_LOG_BRIDGE was never set in the runtime container env, so is_enabled() returned False and the bridge never started. runtime_error_triage stayed at 0 rows. Enable the feature flag in both omninode-runtime and runtime-effects service hardcoded_env so boot path at service_kernel.py:1127-1163 attaches the bridge handler to aiokafka/asyncpg/aiohttp/uvicorn loggers and begins emitting ModelRuntimeErrorEvent to Kafka. DoD on OMN-6972 was also corrected: it referenced a nonexistent runtime_error_events table; the actual projection is runtime_error_triage.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughTwo Docker service configuration files were updated to enable runtime log bridge functionality by adding the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
jonahgabriel
enabled auto-merge
April 11, 2026 07:45
jonahgabriel
added this pull request to the merge queue
Apr 11, 2026
jonahgabriel
deleted the
jonahgabriel/omn-6972-add-runtime-error-emitter
branch
April 11, 2026 08:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enables
ENABLE_RUNTIME_LOG_BRIDGE=trueinomninode-runtimeandruntime-effectsservice catalog yaml soRuntimeLogEventBridge.is_enabled()returns True and the bridge actually starts at boot.Context
The emitter code (
RuntimeLogEventBridge) and consumer (HandlerRuntimeErrorTriage) have been onmainfor weeks — built under OMN-5521 / OMN-5525 and wired intoservice_kernel.pyat lines 111, 684, 1127-1163, 2776, 3090+. The bridge is gated behind theENABLE_RUNTIME_LOG_BRIDGEfeature flag, which was never set in the runtime container env. Result:runtime_error_triagetable sitting at 0 rows on.201:5436 omnibase_infradespite all wiring being in place.Change
Two single-line additions to
hardcoded_envblocks:docker/catalog/services/omninode-runtime.yamldocker/catalog/services/runtime-effects.yamlBoth services boot through
service_kernel.py, so both should capture logger errors and emit to the runtime error topic.OMN-6972 scope correction
The original OMN-6972 DoD referenced a
runtime_error_eventstable that does not exist. The actual projection table isruntime_error_triage. Linear DoD has been updated to reflect the correct name.Test plan
psql -h 192.168.86.201 -p 5436 -U postgres -d omnibase_infra -c "SELECT COUNT(*) FROM runtime_error_triage"returns >0 within ~10 minutes of runtime trafficdocker logs omninode-runtime | grep "RuntimeLogEventBridge started"is presentCoordinates with task #3 (integrator redeploy cycle) — this env var change should be bundled into the active rebuild.
Summary by CodeRabbit