Skip to content

feat(runtime): enable RuntimeLogEventBridge via feature flag [OMN-6972] - #1228

Merged
jonahgabriel merged 1 commit into
mainfrom
jonahgabriel/omn-6972-add-runtime-error-emitter
Apr 11, 2026
Merged

jonahgabriel merged 1 commit into
mainfrom
jonahgabriel/omn-6972-add-runtime-error-emitter

Conversation

@jonahgabriel

@jonahgabriel jonahgabriel commented Apr 11, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Enables ENABLE_RUNTIME_LOG_BRIDGE=true in omninode-runtime and runtime-effects service catalog yaml so RuntimeLogEventBridge.is_enabled() returns True and the bridge actually starts at boot.

Context

The emitter code (RuntimeLogEventBridge) and consumer (HandlerRuntimeErrorTriage) have been on main for weeks — built under OMN-5521 / OMN-5525 and wired into service_kernel.py at lines 111, 684, 1127-1163, 2776, 3090+. The bridge is gated behind the ENABLE_RUNTIME_LOG_BRIDGE feature flag, which was never set in the runtime container env. Result: runtime_error_triage table sitting at 0 rows on .201:5436 omnibase_infra despite all wiring being in place.

Change

Two single-line additions to hardcoded_env blocks:

  • docker/catalog/services/omninode-runtime.yaml
  • docker/catalog/services/runtime-effects.yaml

Both services boot through service_kernel.py, so both should capture logger errors and emit to the runtime error topic.

OMN-6972 scope correction

The original OMN-6972 DoD referenced a runtime_error_events table that does not exist. The actual projection table is runtime_error_triage. Linear DoD has been updated to reflect the correct name.

Test plan

  • Post-redeploy: psql -h 192.168.86.201 -p 5436 -U postgres -d omnibase_infra -c "SELECT COUNT(*) FROM runtime_error_triage" returns >0 within ~10 minutes of runtime traffic
  • docker logs omninode-runtime | grep "RuntimeLogEventBridge started" is present
  • Runtime Errors dashboard surfaces real entries

Coordinates with task #3 (integrator redeploy cycle) — this env var change should be bundled into the active rebuild.

Summary by CodeRabbit

  • Chores
    • Updated container runtime service configurations to introduce a new environment variable enabling runtime logging bridge functionality across containerized environments. This setting has been applied to multiple runtime services within the platform. The change provides improved logging and observability capabilities to support enhanced monitoring and diagnostic features across the runtime infrastructure.

…IDGE=true [OMN-6972]

The RuntimeLogEventBridge emitter (OMN-5521) and HandlerRuntimeErrorTriage
consumer (OMN-5525) have been on main for weeks, but ENABLE_RUNTIME_LOG_BRIDGE
was never set in the runtime container env, so is_enabled() returned False
and the bridge never started. runtime_error_triage stayed at 0 rows.

Enable the feature flag in both omninode-runtime and runtime-effects service
hardcoded_env so boot path at service_kernel.py:1127-1163 attaches the bridge
handler to aiokafka/asyncpg/aiohttp/uvicorn loggers and begins emitting
ModelRuntimeErrorEvent to Kafka.

DoD on OMN-6972 was also corrected: it referenced a nonexistent
runtime_error_events table; the actual projection is runtime_error_triage.
@coderabbitai

coderabbitai Bot commented Apr 11, 2026 •

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: dc6d3f8b-3285-4575-9a26-27a5fa1aefb6

📥 Commits

Reviewing files that changed from the base of the PR and between c5a74a2 and 9f3a0bb.

📒 Files selected for processing (2)
  • docker/catalog/services/omninode-runtime.yaml
  • docker/catalog/services/runtime-effects.yaml

📝 Walkthrough

Walkthrough

Two Docker service configuration files were updated to enable runtime log bridge functionality by adding the ENABLE_RUNTIME_LOG_BRIDGE environment variable set to true.

Changes

Cohort / File(s) Summary
Runtime Service Configurations
docker/catalog/services/omninode-runtime.yaml, docker/catalog/services/runtime-effects.yaml
Added hardcoded environment variable ENABLE_RUNTIME_LOG_BRIDGE: 'true' to enable runtime log bridging in both services.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 The bridge is built, the logs will flow,
Two services now put on a show,
Runtime whispers, a bridge so bright,
Enable the logs—all set just right! 🌉

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The pull request title accurately summarizes the main change: enabling a runtime feature flag (ENABLE_RUNTIME_LOG_BRIDGE) across service configurations, and directly corresponds to the changeset of adding this environment variable to two YAML files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch jonahgabriel/omn-6972-add-runtime-error-emitter

Comment @coderabbitai help to get the list of available commands and usage tips.

@jonahgabriel
jonahgabriel enabled auto-merge April 11, 2026 07:45
@jonahgabriel
jonahgabriel added this pull request to the merge queue Apr 11, 2026
Merged via the queue into main with commit 9d3d80c Apr 11, 2026
64 checks passed
@jonahgabriel
jonahgabriel deleted the jonahgabriel/omn-6972-add-runtime-error-emitter branch April 11, 2026 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant