Skip to content

fix(OMN-8025): add OMNIBASE_INFRA_SAVINGS_KAFKA_BOOTSTRAP_SERVERS to runtime hardcoded_env - #1218

Merged
jonahgabriel merged 1 commit into
mainfrom
jonah/omn-8025-savings-env-fix
Apr 9, 2026
Merged

jonahgabriel merged 1 commit into
mainfrom
jonah/omn-8025-savings-env-fix

Conversation

@jonahgabriel

@jonahgabriel jonahgabriel commented Apr 9, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • ConfigSavingsEstimation uses env_prefix="OMNIBASE_INFRA_SAVINGS_" so it reads OMNIBASE_INFRA_SAVINGS_KAFKA_BOOTSTRAP_SERVERS, not the generic KAFKA_BOOTSTRAP_SERVERS that is already in the runtime container
  • Without this var, the in-kernel savings estimation consumer silently fails to start at runtime: Failed to start savings estimation consumer, continuing without it
  • This is a hardcoded_env fix (container-to-container address redpanda:9092, per CLAUDE.md rule: container-to-container addresses must live in hardcoded_env)

Test plan

  • Verify omninode-runtime logs show Savings estimation consumer started after redeploy
  • Emit {"session_id":"e2e-test-savings-xxx",...} to onex.evt.omniclaude.session-ended.v1 and verify row appears in omnidash_analytics.savings_estimates
  • Check /api/savings/summary returns non-null total

Summary by CodeRabbit

  • Chores
    • Updated Kafka connectivity configuration for the runtime infrastructure.

…runtime hardcoded_env

ConfigSavingsEstimation uses env_prefix="OMNIBASE_INFRA_SAVINGS_" so the
in-kernel consumer reads OMNIBASE_INFRA_SAVINGS_KAFKA_BOOTSTRAP_SERVERS, not
KAFKA_BOOTSTRAP_SERVERS. Without this the savings estimation consumer silently
fails to start at runtime with "Failed to start savings estimation consumer".
@coderabbitai

coderabbitai Bot commented Apr 9, 2026 •

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: f2a768e7-48c0-4c6c-9270-f39f7c6cbcae

📥 Commits

Reviewing files that changed from the base of the PR and between 9a3b329 and 58fcb7f.

📒 Files selected for processing (1)
  • docker/catalog/services/omninode-runtime.yaml

📝 Walkthrough

Walkthrough

A single hardcoded environment variable OMNIBASE_INFRA_SAVINGS_KAFKA_BOOTSTRAP_SERVERS is added to the OmniNode runtime service configuration, pointing to the Redpanda Kafka bootstrap server. No other configuration or control flow changes are introduced.

Changes

Cohort / File(s) Summary
Configuration
docker/catalog/services/omninode-runtime.yaml
Added hardcoded environment variable OMNIBASE_INFRA_SAVINGS_KAFKA_BOOTSTRAP_SERVERS set to redpanda:9092 alongside existing Kafka settings.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Poem

🐰 A whisker-twitch to Kafka's dance,
Where Redpanda leads the conference!
Bootstrap servers, set with care,
Environment variables in the air ✨
Savings streams flow everywhere! 🌊

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: adding a required environment variable to the runtime configuration to fix a known issue (OMN-8025).
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch jonah/omn-8025-savings-env-fix

Comment @coderabbitai help to get the list of available commands and usage tips.

@jonahgabriel
jonahgabriel added this pull request to the merge queue Apr 9, 2026
Merged via the queue into main with commit edd3be7 Apr 9, 2026
64 checks passed
@jonahgabriel
jonahgabriel deleted the jonah/omn-8025-savings-env-fix branch April 9, 2026 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant