Repository navigation
fix(OMN-8025): add OMNIBASE_INFRA_SAVINGS_KAFKA_BOOTSTRAP_SERVERS to runtime hardcoded_env - #1218
Conversation
…runtime hardcoded_env ConfigSavingsEstimation uses env_prefix="OMNIBASE_INFRA_SAVINGS_" so the in-kernel consumer reads OMNIBASE_INFRA_SAVINGS_KAFKA_BOOTSTRAP_SERVERS, not KAFKA_BOOTSTRAP_SERVERS. Without this the savings estimation consumer silently fails to start at runtime with "Failed to start savings estimation consumer".
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughA single hardcoded environment variable Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Summary
ConfigSavingsEstimationusesenv_prefix="OMNIBASE_INFRA_SAVINGS_"so it readsOMNIBASE_INFRA_SAVINGS_KAFKA_BOOTSTRAP_SERVERS, not the genericKAFKA_BOOTSTRAP_SERVERSthat is already in the runtime containerFailed to start savings estimation consumer, continuing without ithardcoded_envfix (container-to-container addressredpanda:9092, per CLAUDE.md rule: container-to-container addresses must live inhardcoded_env)Test plan
omninode-runtimelogs showSavings estimation consumer startedafter redeploy{"session_id":"e2e-test-savings-xxx",...}toonex.evt.omniclaude.session-ended.v1and verify row appears inomnidash_analytics.savings_estimates/api/savings/summaryreturns non-null totalSummary by CodeRabbit