Skip to content

feat(OMN-20565): exposed-identifier gate as a check-compute node with a git-listing effect node - #1896

Merged
jonahgabriel merged 1 commit into
devfrom
jonah/omn-20565-exposed-identifiers-node
Oct 6, 2026
Merged

jonahgabriel merged 1 commit into
devfrom
jonah/omn-20565-exposed-identifiers-node

Conversation

@jonahgabriel

@jonahgabriel jonahgabriel commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor

OMN-20565 row 7. The exposed-identifier gate (byte-identical script in omnibase_infra and omnimarket) becomes canonical nodes.

  • New EFFECT node node_git_file_listing_effect: the only place git is spawned (ls-files for scope all, diff for scope diff, with the oracle's fallback to all when the base ref is missing).
  • New COMPUTE node node_exposed_identifiers_check_compute: pure definition-B handler returning the canonical validation report. Salted-hash windowed matching, overlap collapse and the per-line allow annotation reproduce the oracle; findings never print the matched value.
  • Runtime with --denylist (required, no default), --root, --scope, --base-ref, --mode, --report-json; a full-tree run that scans zero files is an ERROR, a bad denylist exits 2.
  • Hook exposed-identifier-gate in .pre-commit-hooks.yaml. This repo carries no denylist and does not wire the hook on itself; consumers pass their own.
  • node_source_file_gather_effect gains a lossless surrogateescape decode mode so the binary-byte check sees the original bytes.
  • Parity: committed golden generated from the oracle against a synthetic denylist (no real literal anywhere), including a negative check that removing an expected finding fails the test.

Lab: h202, uv run pytest tests/unit/nodes/node_exposed_identifiers_check_compute tests/unit/nodes/node_git_file_listing_effect tests/unit/nodes/node_source_file_gather_effect -q, 83 passed, head=b3e9a147db2d5590330b91d749b214b36d098b2b

Evidence-Ticket: OMN-20565
Evidence-Source: OCC#13084

…ck-compute node with a git-listing effect node
@jonahgabriel
jonahgabriel requested a review from a team as a code owner October 6, 2026 21:13
@jonahgabriel
jonahgabriel enabled auto-merge (squash) October 6, 2026 21:14
jonahgabriel pushed a commit to OmniNode-ai/onex_change_control that referenced this pull request Oct 6, 2026
…13084)

* evidence(OMN-20565): author OCC companion for OmniNode-ai/omnibase_core#1896

OCC companion by node_pr_lifecycle_fix_effect (OMN-13317 F1 / OMN-13990 / OMN-14285). Product PR head b3e9a147db2d5590330b91d749b214b36d098b2b.

* evidence(OMN-20565): self-bind OCC#13084 + rebind contract_sha256

---------

Co-authored-by: omnimarket-bot <bot@omninode.ai>
@jonahgabriel
jonahgabriel merged commit b9463d3 into dev Oct 6, 2026
300 of 315 checks passed
@jonahgabriel
jonahgabriel deleted the jonah/omn-20565-exposed-identifiers-node branch October 6, 2026 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant