Repository navigation
fix(OMN-20525): pin bump banner reuses the indent of the line it replaces - #1883
Merged
Merged
Conversation
jonahgabriel
pushed a commit
to OmniNode-ai/onex_change_control
that referenced
this pull request
Oct 4, 2026
…12787) * evidence(OMN-20525): author OCC companion for OmniNode-ai/omnibase_core#1883 OCC companion by node_pr_lifecycle_fix_effect (OMN-13317 F1 / OMN-13990 / OMN-14285). Product PR head 61e5a3c7b0f2f382d156ed6186acd8413c8f6d99. * evidence(OMN-20525): self-bind OCC#12787 + rebind contract_sha256 --------- Co-authored-by: omnimarket-bot <bot@omninode.ai>
jonahgabriel
enabled auto-merge (squash)
October 4, 2026 11:57
This was referenced Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lab: host=h201 (headless lane pin-bump-indent) head=61e5a3c7b0f2f382d156ed6186acd8413c8f6d99 command='uv run pytest tests/unit/scripts/test_pin_bump.py -q -n 0' observed 23 passed (RED at 445bc2a: 5 failed). Focused file only, run in the lane worktree; pre-commit hooks ran on both commits.
fix(OMN-20525): pin bump banner reuses the indent of the line it replaces
Problem
scripts/pin_bump.py_rewrite_bannerbuilt the banner with 10 hard-coded leading spaces, whileBANNER_OLD_RE/BANNER_ANY_OLD_REbegan at#. This caused the old indent to remain in front, adding +8 spaces per bump. This pushedomninode_infra.github/workflows/check-handshake.yml:29over yamllint max 150 (omninode_infra#1797).Fix
Both regexes now capture the line's leading whitespace; the replacement reuses it (two-line form keeps the first line's indent). Pin-site rewriting is untouched.
Verification
445bc2a142: 5 new tests fail (e.g. banner length 99 vs 109 after two bumps).61e5a3c7b0:tests/unit/scripts/test_pin_bump.py23 passed.Impact Survey
Survey of open bot/bump-omnibase-core-pin-* PRs (banner line length after bump, limit 150):
None exceed 150.
Note: omnimemory#579, omniintelligence#1000, omnibase_spi#342, omnibase_infra#4553 are already MERGED.
Evidence-Ticket: OMN-20525
Evidence-Source: OCC#12787