Repository navigation
chore(OMN-16914): add omninode_infra to dependency-cascade downstream matrix - #1613
Merged
github-actions[bot] merged 1 commit intoAug 29, 2026
Conversation
…cascade downstream matrix omninode_infra pins omnibase-core as a dev-only dependency (pyproject.toml) but was never added to .github/workflows/dependency-cascade.yml's omnibase_core downstream matrix -- every other core-consuming repo gets an automated bump PR on each core release; omninode_infra never did, which is exactly why its pin sat 4 minors stale with nothing to catch it (see the companion pin-bump PR, omninode_infra#1058, also under OMN-16914). Change: add "omninode_infra" to the omnibase_core case's REPOS list in compute-matrix, and to the docstring's downstream-mapping comment. Scoped to the omnibase_core case only -- omninode_infra does not depend on omnibase-spi or omnibase-infra, so those cases are untouched (mirrors the existing onex_change_control precedent, which is core-only for the same reason). The onexbot-occ-writer GitHub App (which the open-bump-pr job uses to push/PR into each downstream repo) has repository_selection: "all" on the OmniNode-ai org -- verified live via `gh api orgs/OmniNode-ai/installations`, confirming it already has write access to omninode_infra with no additional App wiring needed. Verification: - tests/scripts/test_dependency_cascade_matrix.py: 15/15 pass (parses the case-mapping and asserts non-empty/unique/expected downstream sets -- no hardcoded assertion on the omnibase_core list's exact membership breaks from this addition) - ruff format --check / ruff check: clean - pre-commit run --files .github/workflows/dependency-cascade.yml: all hooks pass Evidence-Ticket: OMN-16914
Contributor
|
Warning Review limit reachedNext included review available in 17 minutes. View limit detailsLimit details: You’ve used the included review currently available. Your 132 included PR review attempts over the past 7 days set your current allowance at 1 review per hour. Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
Comment |
github-actions
Bot
deleted the
jonah/omn-16914-dependency-cascade-add-omninode-infra
branch
August 29, 2026 04:49
jonahgabriel
added a commit
that referenced
this pull request
Sep 4, 2026
…push workflows fire (#1646) auto-merge.yml armed 'gh pr merge --auto' with the default workflow token. GitHub completes an armed auto-merge as the identity that armed it, and fires no push event for commits authored by that default token, so every push-on-dev workflow was skipped on every PR that landed through this job. Measured 2026-09-04T15:20-15:25Z over the 30 most recently merged dev PRs (#1613-#1645), via gh api "repos/OmniNode-ai/omnibase_core/actions/runs?head_sha=<full-oid>&event=push" --jq .total_count all 20 bot merges had 0 dev-branch push runs; all 10 jonahgabriel merges had 12-14. The human counts are the positive control that makes those zeros evidence of absence rather than a broken query. Swap the two merge-state-mutating steps to secrets.CROSS_REPO_PAT (existing org secret, visibility=all, already consumed by seven workflows in this repo). The read-only pre-check resolve step stays on the default token: it creates no commit. No fallback expression, which would restore the defect silently. Port of omnibase_infra#3178. Co-authored-by: jonahgabriel <jonah.neugass@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
omninode_infrapinsomnibase-coreas a dev-only dependency(
pyproject.toml) but was never in.github/workflows/dependency-cascade.yml'somnibase_coredownstreammatrix. Every other core-consuming repo gets an automated bump PR on
each core release;
omninode_infranever did, which is exactly why itspin sat 4 minors stale with nothing to catch it -- confirmed live: it
was pinned
>=0.42.0,<0.43.0against a released0.46.13. Companionpin-bump PR:
omninode_infra#1058(merged), same ticket.Change
Add
"omninode_infra"to theomnibase_corecase'sREPOSlist incompute-matrix, and to the docstring's downstream-mapping comment.Scoped to the
omnibase_corecase only --omninode_infradoes notdepend on
omnibase-spioromnibase-infra, so those cases areuntouched (mirrors the existing
onex_change_controlprecedent, whichis core-only for the same reason).
The
onexbot-occ-writerGitHub App (used byopen-bump-prto push/PRinto each downstream repo) has
repository_selection: "all"on theOmniNode-aiorg -- verified live viagh api orgs/OmniNode-ai/installations, confirming it already haswrite access to
omninode_infrawith no additional App wiring needed.Verification
tests/scripts/test_dependency_cascade_matrix.py: 15/15 pass (parsesthe case-mapping and asserts non-empty/unique/expected downstream
sets -- no hardcoded assertion on the
omnibase_corelist's exactmembership breaks from this addition)
ruff format --check/ruff check: cleanpre-commit run --files .github/workflows/dependency-cascade.yml:all hooks pass
scripts/hooks/prepush_smart_tests.sh,OMN-13973): 44256 passed, 53 skipped, 3 xpassed, 0 failed
Evidence-Ticket: OMN-16914
Evidence-Source: OCC#7515