Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .claude/settings.local.json
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,8 @@
"Bash(yamllint:*)",
"mcp__serena__replace_symbol_body",
"mcp__archon__establish_performance_baseline",
"mcp__serena__insert_after_symbol"
"mcp__serena__insert_after_symbol",
"WebSearch"
],
"deny": [],
"ask": []
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ci-cd.yml
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ jobs:
ONEX_DATABASE__URL: postgresql://test:test@localhost:5432/onex_test
ONEX_ENVIRONMENT: test
run: |
# Run integration tests without requiring omnibase-spi dependency
# Run integration tests without requiring omnibase_spi dependency
echo "Integration tests would run here with external services"
echo "PostgreSQL: $(pg_isready -h localhost -p 5432 && echo 'Ready' || echo 'Not ready')"
echo "Redis: $(redis-cli -h localhost -p 6379 ping || echo 'Not ready')"
Expand Down
4 changes: 2 additions & 2 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ repos:
# Union Usage Validation
- id: validate-union-usage
name: ONEX Union Usage Validation
entry: python scripts/validate-union-usage.py --max-unions 6700
entry: python scripts/validate-union-usage.py --max-unions 7000
language: system
pass_filenames: false
files: ^src/.*\.py$
Expand Down Expand Up @@ -107,7 +107,7 @@ repos:
# Configuration
ci:
autofix_commit_msg: |
[pre-commit.ci] auto fixes for omnibase-core
[pre-commit.ci] auto fixes for omnibase_core

for more information, see https://pre-commit.ci
autofix_prs: true
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -121,10 +121,10 @@ class CustomNodeService(NodeComputeService, MixinHealthCheck, MixinMetrics):
## Implementation Examples

### Reference Locations
- **Current Implementation**: `/Volumes/PRO-G40/Code/omnibase-core`
- **Current Implementation**: `/Volumes/PRO-G40/Code/omnibase_core`
- **Reference Architecture**: `/Volumes/PRO-G40/Code/omnibase_3/tools/infrastructure`
- **Example Implementations**: `src/omnibase_core/examples/tool_infrastructure_*/`
- **Developer Guide**: `/Volumes/PRO-G40/Code/omnibase-core/docs/ONEX_4_Node_System_Developer_Guide.md`
- **Developer Guide**: `/Volumes/PRO-G40/Code/omnibase_core/docs/ONEX_4_Node_System_Developer_Guide.md`

### Usage Patterns
```python
Expand Down
2 changes: 1 addition & 1 deletion ANTI_PATTERN_REMEDIATION_PLAN.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

## Summary

This document outlines a comprehensive plan to eliminate type safety anti-patterns throughout the omnibase-core codebase, following the **Strong Typing Only - No Fallbacks** architectural principle.
This document outlines a comprehensive plan to eliminate type safety anti-patterns throughout the omnibase_core codebase, following the **Strong Typing Only - No Fallbacks** architectural principle.

## Anti-Pattern Categories Found

Expand Down
2 changes: 1 addition & 1 deletion CLAUDE.md
Original file line number Diff line number Diff line change
Expand Up @@ -665,7 +665,7 @@ class TestReducerPatternIntegration:

```bash
# Clone and setup project
cd /Volumes/PRO-G40/Code/omnibase-core
cd /Volumes/PRO-G40/Code/omnibase_core
poetry install

# Create feature branch
Expand Down
6 changes: 3 additions & 3 deletions DOWNSTREAM_DEVELOPMENT.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ cd your-repo-name

# Add omnibase_core dependency
poetry add omnibase_core --path ../omnibase_core --editable
poetry add omnibase-spi --git git@github.com:YourOrg/omnibase-spi.git
poetry add omnibase_spi --git https://github.com/YourOrg/omnibase_spi.git

# Install development dependencies
poetry add --group dev pytest mypy ruff pre-commit
Expand Down Expand Up @@ -214,10 +214,10 @@ except Exception as e:
**Solution:**
```bash
# Ensure omnibase-spi is properly installed
poetry add omnibase-spi --git git@github.com:YourOrg/omnibase-spi.git
poetry add omnibase_spi --git https://github.com/YourOrg/omnibase_spi.git

# Or if using SSH keys:
poetry run pip install git+ssh://git@github.com/YourOrg/omnibase-spi.git
poetry run pip install git+https://github.com/YourOrg/omnibase_spi.git
```

### Issue: Union Type Validation Failures
Expand Down
2 changes: 1 addition & 1 deletion METADATA_ELIMINATION_PLAN.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

## 🎯 Objective

Eliminate ALL raw dictionary metadata patterns throughout omnibase-core and replace with **strongly-typed Pydantic models** that:
Eliminate ALL raw dictionary metadata patterns throughout omnibase_core and replace with **strongly-typed Pydantic models** that:

1. **Start with "Model" prefix** (naming standards compliance)
2. **Use NO basic types** or `Dict[str, Any]` that will require future refactoring
Expand Down
2 changes: 1 addition & 1 deletion ONEX_MIXIN_SYSTEM_RESEARCH.md
Original file line number Diff line number Diff line change
Expand Up @@ -257,4 +257,4 @@ For implementing an error handling mixin, follow the established patterns docume
---
*Research conducted on: 2025-01-02*
*Research scope: Complete ONEX mixin architecture investigation*
*Codebase: omnibase-core (canary implementation)*
*Codebase: omnibase_core (canary implementation)*
14 changes: 7 additions & 7 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ Foundational implementations for the ONEX framework, providing base classes, dep

## Overview

This repository contains the core building blocks that all ONEX tools and services inherit from. It implements the contracts defined in `omnibase-spi` and provides the foundational architecture for the 4-node ONEX pattern.
This repository contains the core building blocks that all ONEX tools and services inherit from. It implements the contracts defined in `omnibase_spi` and provides the foundational architecture for the 4-node ONEX pattern.

## Architecture Principles

Expand Down Expand Up @@ -74,7 +74,7 @@ authors = [{name = "OmniNode Team", email = "team@omninode.ai"}]
license = {text = "MIT"}
requires-python = ">=3.11"
dependencies = [
"omnibase-spi>=0.1.0",
"omnibase_spi>=0.1.0",
"pydantic>=2.0.0",
"llama-index>=0.10.0",
"fastapi>=0.100.0",
Expand Down Expand Up @@ -144,8 +144,8 @@ find src/omnibase -type d -exec touch {}/__init__.py \;
python -m venv venv
source venv/bin/activate

# Install dependencies (after omnibase-spi is packaged)
pip install -e ../omnibase-spi
# Install dependencies (after omnibase_spi is packaged)
pip install -e ../omnibase_spi
pip install -e .[dev]
```

Expand Down Expand Up @@ -259,12 +259,12 @@ class YourTool(NodeTypeService): # EFFECT/COMPUTE/REDUCER/ORCHESTRATOR
- **No isinstance checks**: Use duck typing through protocols
- **No registry dependencies**: Pure protocol-based resolution

## Integration with omnibase-spi
## Integration with omnibase_spi

This repository implements the protocols defined in omnibase-spi:
This repository implements the protocols defined in omnibase_spi:

```python
# Protocol definition (in omnibase-spi)
# Protocol definition (in omnibase_spi)
class ProtocolEventBus(Protocol):
def publish(self, event: ModelEvent) -> None: ...

Expand Down
2 changes: 1 addition & 1 deletion REDUCER_PATTERN_ENGINE_IMPLEMENTATION_PLAN.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

## Executive Summary

This document outlines the comprehensive implementation plan for the Reducer Pattern Engine, a core architectural component for multi-workflow execution in the omnibase-core system. Based on Archon ticket ccf4203c-639c-49a9-8e11-46cf136461a2, this plan addresses the key requirements for workflow routing, subreducer frameworks, instance isolation, and integration with the existing ONEX 4-node architecture.
This document outlines the comprehensive implementation plan for the Reducer Pattern Engine, a core architectural component for multi-workflow execution in the omnibase_core system. Based on Archon ticket ccf4203c-639c-49a9-8e11-46cf136461a2, this plan addresses the key requirements for workflow routing, subreducer frameworks, instance isolation, and integration with the existing ONEX 4-node architecture.

## 1. Architecture Overview

Expand Down
10 changes: 5 additions & 5 deletions RESEARCH_REPORT_4_NODE_ARCHITECTURE.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,12 @@

**Research Date**: January 30, 2025
**Research Scope**: Comprehensive analysis of proper 4-node architecture implementation
**Target Systems**: omnibase-core vs omnibase_3 reference implementation
**Target Systems**: omnibase_core vs omnibase_3 reference implementation
**Status**: Complete

## Executive Summary

This research provides a comprehensive analysis of the proper 4-node architecture pattern by examining both the reference implementation (omnibase_3) and the current implementation (omnibase-core). The analysis covers node patterns, service architecture, contract systems, and mixin composition to understand the complete architectural framework.
This research provides a comprehensive analysis of the proper 4-node architecture pattern by examining both the reference implementation (omnibase_3) and the current implementation (omnibase_core). The analysis covers node patterns, service architecture, contract systems, and mixin composition to understand the complete architectural framework.

**Key Findings:**
- Current implementation successfully implements all 4 specialized node types
Expand Down Expand Up @@ -46,9 +46,9 @@ The reference documentation defines a clear 4-node classification system:
- **Characteristics**: Thunk emission, dependency management
- **Examples**: Workflow engines, conditional branching, load balancing

### 1.2 Current Implementation Analysis (omnibase-core)
### 1.2 Current Implementation Analysis (omnibase_core)

**Location**: `/Volumes/PRO-G40/Code/omnibase-core/src/omnibase_core/core/`
**Location**: `/Volumes/PRO-G40/Code/omnibase_core/src/omnibase_core/core/`

#### NodeCoreBase Foundation
All specialized nodes inherit from `NodeCoreBase` providing:
Expand Down Expand Up @@ -380,7 +380,7 @@ metadata_loader = container.get_service("ProtocolSchemaLoader")

### 8.1 Current Implementation Assessment

The current omnibase-core implementation demonstrates **excellent alignment** with the reference architecture standards. All 4 node types are properly implemented with:
The current omnibase_core implementation demonstrates **excellent alignment** with the reference architecture standards. All 4 node types are properly implemented with:

- Clear separation of responsibilities matching reference classification
- Robust contract system for configuration management
Expand Down
2 changes: 1 addition & 1 deletion SETUP_COMPLETION_SUMMARY.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

### Environment Setup
- **Python Version**: Fixed compatibility (^3.11 instead of ^3.12)
- **Poetry Dependencies**: Successfully installed all dependencies including omnibase-spi v0.0.2
- **Poetry Dependencies**: Successfully installed all dependencies including omnibase_spi v0.0.2
- **Package Structure**: Migrated from `src/omnibase/` to `src/omnibase_core/`
- **Pre-commit Hooks**: Installed and configured with ONEX standards

Expand Down
12 changes: 6 additions & 6 deletions SETUP_STATUS.md
Original file line number Diff line number Diff line change
Expand Up @@ -46,14 +46,14 @@
- YAML formatting with yamlfmt
- File formatting (trailing whitespace, EOF, merge conflicts)
- Python formatting (Black + isort) with exact same versions/args
- Ruff linting for omnibase-core specific needs
- Ruff linting for omnibase_core specific needs
- MyPy type checking focused on core framework files
- ✅ Ready for development environment setup

## Pending Tasks (Blocked by omnibase-spi)
## Pending Tasks (Blocked by omnibase_spi)

### 1. Development Environment Setup
- ⏳ Install dependencies (requires omnibase-spi to be packaged first)
- ⏳ Install dependencies (requires omnibase_spi to be packaged first)
- ⏳ Virtual environment setup with `pip install -e .[dev]`

### 2. Code Quality Validation
Expand All @@ -63,7 +63,7 @@
- ⏳ Run tests: `make test`

### 3. Node Service Base Classes
- ⏳ Complete implementation depends on omnibase-spi protocols
- ⏳ Complete implementation depends on omnibase_spi protocols
- ⏳ Current base classes may need updates once SPI contracts are available

## Current Architecture Benefits
Expand All @@ -77,15 +77,15 @@

## Next Steps

1. **Wait for omnibase-spi packaging** to become available
1. **Wait for omnibase_spi packaging** to become available
2. **Install development dependencies**: `make install-dev`
3. **Run quality checks**: `make quality`
4. **Validate example implementations** against new architecture
5. **Create comprehensive tests** for all base classes

## Development Workflow

Once omnibase-spi is available:
Once omnibase_spi is available:

```bash
# Setup development environment
Expand Down
Loading