Repository navigation
ci(OMN-13911): wire Handshake Policy Gate as a live merge_group check - #1383
Conversation
Handshake Policy Gate (org-wide architecture-handshake audit) only triggered on schedule + workflow_dispatch, so a broken handshake in any active repo could go unnoticed for up to a week without ever surfacing as a check on any PR. Add pull_request + merge_group triggers mirroring url-authority-gate.yml / canonical-inference-gate.yml, matching the pattern already merged for the sibling OMN-13875 fixes (omnibase_infra #2188, omnibase_spi #254, omniintelligence #746). Not added to required-status-checks: that flip is a separate, staged decision, and POLICY_GATE_TOKEN (a cross-repo PAT) is unavailable to fork PRs, so this job cannot be a hard blocker yet.
Live evidence on this PR (#1381) showed the pull_request trigger makes the job permanently red: "ERROR: GitHub CLI is not authenticated." Root cause is this repo's own OMNI_RUNNER_SELECTOR_V1 convention (see ci.yml) which routes every pull_request-triggered job to the public ubuntu-latest runner regardless of fork status, withholding POLICY_GATE_TOKEN by design. merge_group is a distinct event_name (not pull_request), so it correctly reaches the trusted self-hosted runner where the token is available. Keeping merge_group-only still satisfies the goal (a live pre-merge signal instead of only weekly) without shipping an always-failing, non-actionable check on every PR.
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 25 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
Auto-merged by merge-sweep | correlation_id: |
|
Auto-merged by merge-sweep | correlation_id: |
OMN-13911 (child of OMN-13875) — omnibase_core finding: decorative CI gate
Problem
Handshake Policy Gate(.github/workflows/handshake-policy-gate.yml) only triggered onschedule(weekly Monday 08:00 UTC) andworkflow_dispatch. It never ran onpull_requestormerge_group, so a broken architecture-handshake in any active OmniNode repo could go unnoticed for up to a week — the check existed but was never a live, observable pre-merge signal. Same decorative-gate class as the other four OMN-13875 findings (omnibase_infra #2188, omnibase_spi #254, omniintelligence #746 — all merged).Fix (revised after live evidence)
My first attempt added both
pull_requestandmerge_grouptriggers, mirroringurl-authority-gate.yml/canonical-inference-gate.yml. Live CI immediately showed "Check handshake compliance across repos" failing with "ERROR: GitHub CLI is not authenticated" — this job needsPOLICY_GATE_TOKEN, and this repo's ownOMNI_RUNNER_SELECTOR_V1convention (used throughoutci.yml) routes everypull_request-triggered job to the publicubuntu-latestrunner regardless of fork status, withholding trusted secrets by design.pull_requestwould have made this job permanently red on every future PR.Final fix drops
pull_request, keepsmerge_grouponly (a distinct, non-pull_requestevent_name, correctly reaching the trusted self-hosted runner where the token works):on: schedule: - cron: '0 8 * * 1' + merge_group: workflow_dispatch:Scope / wedge-safety
Deliberately NOT added to required-status-checks — that flip is a separate, staged decision.
Verification
Workflow-YAML-only change, zero Python touched:
yaml.safe_loadOK both iterations;uv run pre-commit run --files .github/workflows/handshake-policy-gate.ymlall applicable hooks Passed both iterations;uv run pytest tests/ -v(no-k) launched as the mandatory full-suite pre-push check (zero blast radius expected — no Python source/test file touched).OCC evidence
This is a child ticket (OMN-13911) of OMN-13875, carved out because the parent's shared contract already has 3 dod_evidence entries and cannot accept a 4th consumer without forcing a rewrite of already-merged receipts (OMN-13888 defect class).
Evidence-Source: OCC#3546
Evidence-Ticket: OMN-13911