Repository navigation
ci(OMN-13309): wire no-plugin-daemon-classes validator as required CI gate - #1336
Conversation
… gate W9 of the validator-standardization remediation plan. The canonical Plugin* lifecycle guard (omnibase_core.validators.no_plugin_daemon_classes, landed via core#1280 / OMN-13284) was exported as a remote pre-commit hook and consumed by omnibase_infra, omnimarket, and omniclaude, but was never wired as a server-side CI gate on omnibase_core itself. Per Operating Rule #5 (enforcement, not detection), a pre-commit-only check is advisory and bypassable. This adds the standalone validator-no-plugin-daemon-classes.yml workflow with a unique, requirable status-check context (no-plugin-daemon-classes), mirroring the validator-runtime-profiles.yml / receipt-honesty.yml pattern. The job runs the validator unit tests and self-scans core's own src/ tree (must exit 0). Adds test_omnibase_core_src_tree_is_clean — a self-scan regression that pins the exact contract the CI gate's self-scan step relies on, so a future Plugin* lifecycle class added to core src fails the unit test and the CI gate together. The closed core#1268 attempted this W9 work but bundled an unrelated routing- authority refactor and was closed unmerged; the validator implementation has since landed via core#1280. This PR closes the remaining DoD gap: the CI gate.
|
Warning Review limit reached
More reviews will be available in 12 minutes and 49 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits. 🚦 How do rate limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
1 participant
Summary
Wires the canonical no-plugin-daemon-classes validator as a required server-side CI gate on
omnibase_core. This closes the last open DoD item of OMN-13309 (W9 of the validator-standardization remediation plan).Background — why this PR exists
The W9 validator implementation (
omnibase_core.validators.no_plugin_daemon_classes+ModelPluginLifecycleFinding+ unit tests) already landed via core#1280 (OMN-13284) and is:omnibase_core/.pre-commit-hooks.yamlomnibase_infra,omnimarket, andomniclaudeThe earlier attempt at this work (core#1268) bundled an unrelated routing-authority refactor and was closed unmerged (
mergedAt=null, closed 2026-06-19). The one remaining W9 DoD gap was enforcement: the validator existed only as a pre-commit hook, never as a CI gate. Per Operating Rule #5 ("enforcement, not detection"), a pre-commit-only check is advisory and bypassable.What this PR adds
.github/workflows/validator-no-plugin-daemon-classes.yml— standalone CI gate with a unique, requirable status-check context (no-plugin-daemon-classes), mirroring thevalidator-runtime-profiles.yml(OMN-13330) /receipt-honesty.yml(OMN-13328) pattern. Runs (1) the validator unit tests, (2) a self-scan of core's ownsrc/(must exit 0).tests/unit/validators/test_no_plugin_daemon_classes.py::test_omnibase_core_src_tree_is_clean— a self-scan regression that pins the exact contract the CI gate's self-scan step relies on. Proven to fail on an injectedPluginRogueDaemonand pass when clean.Proof
uv run pytest tests/unit/validators/test_no_plugin_daemon_classes.py -v-> 9 passeduv run python -m omnibase_core.validators.no_plugin_daemon_classes src/-> exit 0uv run mypy --stricton changed surface -> cleanpre-commit run --files ...-> all hooks passOMN-13309
Evidence-Source: OCC#3102
Evidence-Ticket: OMN-13309