Skip to content

Commit

Permalink
Updated deprecated node & python versions in docs & CI
Browse files Browse the repository at this point in the history
Signed-off-by: Omkar Phansopkar <[email protected]>
  • Loading branch information
OmkarPh committed Feb 17, 2024
1 parent 695d971 commit fe6bc1c
Show file tree
Hide file tree
Showing 4 changed files with 16 additions and 17 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/Release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
name: Create Release
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@master
- uses: actions/checkout@v4
# - name: Exit if tag not is not pointing to a commit in master branch
# if: endsWith(github.ref, 'master') == false
# run: exit -1
Expand Down Expand Up @@ -41,13 +41,13 @@ jobs:
os: [ubuntu-latest, macos-latest, windows-latest, macos-14]
runs-on: ${{ matrix.os }}
steps:
- uses: actions/checkout@master
- uses: actions/checkout@v4
- uses: actions/setup-python@v4
with:
python-version: 3.12.0
- uses: actions/setup-node@master
with:
node-version: 16.13.0
node-version: 20
- name: Install dependencies
run: npm install
- name: Create release assets directory
Expand Down
7 changes: 3 additions & 4 deletions .github/workflows/Test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,15 +11,14 @@ jobs:

strategy:
matrix:
node-version: [14.x, 16.x, 18.x]
node-version: [16.x, 18.x, 20.x]
# See supported Node.js release schedule at https://nodejs.org/en/about/releases/

steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v3
uses: actions/setup-node@master
with:
node-version: ${{ matrix.node-version }}
cache: "npm"
- run: npm install
- run: npm test
2 changes: 1 addition & 1 deletion .github/workflows/docs-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:

steps:
- name: Checkout code
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: Set up Python ${{ matrix.python-version }}
uses: actions/setup-python@v4
Expand Down
18 changes: 9 additions & 9 deletions docs/source/contribute/building.rst
Original file line number Diff line number Diff line change
Expand Up @@ -29,18 +29,18 @@ Building Requirements
Linux
-----

- `Python <https://www.python.org/>`__ v3.7 or later
- `Node.js <https://nodejs.org/en//>`__ 14.x or later
- `npm <https://www.npmjs.com/>`__ v6.14.4 or later
- `Python <https://www.python.org/>`__ v3.9 or later
- `Node.js <https://nodejs.org/en//>`__ 16.x or later
- `npm <https://www.npmjs.com/>`__ v8.x or later

.. include:: ../rst_snippets/centos-note.rst

MacOS
-----

- `Python <https://www.python.org/>`__ v3.7 or later
- `Node.js <https://nodejs.org/en/>`__ 14.x or later
- `npm <https://www.npmjs.com/>`__ v6.14.4 or later
- `Python <https://www.python.org/>`__ v3.9 or later
- `Node.js <https://nodejs.org/en/>`__ 16.x or later
- `npm <https://www.npmjs.com/>`__ v8.x or later
- Command Line Tools for `Xcode <https://developer.apple.com/xcode/resources/>`_
Install using:

Expand All @@ -51,16 +51,16 @@ MacOS
Windows
-------

- `Python <https://www.python.org/>`__ v3.7 or later
- `Python <https://www.python.org/>`__ v3.9 or later

* Make sure your Python path is set. To verify, open a command prompt and see the python version:

.. code-block:: bash
python --version
- `Node.js <https://nodejs.org/en/>`__ v14.x or later
- `npm <https://www.npmjs.com/>`__ v6.14.4 or later
- `Node.js <https://nodejs.org/en/>`__ v16.x or later
- `npm <https://www.npmjs.com/>`__ v8.x or later


Release Instructions
Expand Down

0 comments on commit fe6bc1c

Please sign in to comment.