[Hermes Desktop][hermes-desktop-local-ai-thinking-off-default][1/n] Keep thinking off on session start - #88
Merged
Conversation
🔎 Lint report:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Hermes desktop can start with Thinking Off, but the lazy session-start path was still allowed to hydrate an agent with the default reasoning behavior and then report Medium back to the desktop. That made the status/menu flip from Off to Medium as soon as a chat session started.
What changed
none, including the lightweightsession.createresponse emitted before the real agent finishes hydrating.Offinstead of silently relabeling disabled thinking asMed.How to review
tui_gateway/server.pyaround_load_reasoning_config,_reasoning_effort_for_session_info, andsession.create.apps/desktop/src/lib/model-status-label.test.tsandapps/desktop/src/app/shell/model-edit-submenu.test.ts.main.Evidence
/Users/obaradei/.hermes/hermes-agentafter rebasing onto forkmainat PR fix(cli): preserve chat-local provider flags #86./api/wssession.createreturnedreasoning_effort: noneforqwen3.6-27b, then the probe session was closed.Verification
venv/bin/python -m pytest tests/test_tui_gateway_server.py -q -k "reasoning_none or blank_reasoning or session_create_lazy_info"npm run test:ui -- src/lib/model-status-label.test.ts src/app/shell/model-edit-submenu.test.tsRisks / gaps
tests/test_tui_gateway_server.pywas not green locally becausetest_browser_manage_connect_default_local_reports_launch_hintdepends on local browser plugin/environment behavior; accepted risk for this PR because it is outside the changed reasoning/session metadata path and the focused gateway tests cover the regression.hermes-desktop-local-ai-thinking-off-default, so no work item needed here.Collaborators
hermes-desktop-local-ai-thinking-off-default, implemented, rebased live checkout, tested, and verified the live session-start contract.Task: hermes-desktop-local-ai-thinking-off-default