[codex] Rebuild desktop package when install stamp drifts - #82
Merged
Conversation
OmarB97
marked this pull request as ready for review
June 4, 2026 16:45
🔎 Lint report:
|
| Rule | Count |
|---|---|
invalid-assignment |
1 |
invalid-argument-type |
1 |
First entries
hermes_cli/main.py:7304: [invalid-assignment] invalid-assignment: Invalid subscript assignment with key of type `Literal["installIdentity"]` and value of type `dict[str, str | None] & ~AlwaysFalsy` on object of type `dict[str, str | bool]`
tests/hermes_cli/test_gui_command.py:390: [invalid-argument-type] invalid-argument-type: Argument to function `_write_packaged_install_stamp` is incorrect: Expected `dict[str, object]`, found `dict[str, str]`
✅ Fixed issues: none
Unchanged: 5105 pre-existing issues carried over.
Diagnostics are surfaced as warnings — this check never fails the build.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hermes desktop --build-onlycompare the packaged app embeddedinstall-stamp.jsonidentity with the current checkout identity before trusting the content-hash cache.Root Cause
The updater handed off correctly and ran
hermes update, but the rebuild step could sayDesktop packaged app is up to date (content stamp matches)when desktop source content was unchanged. That allowed it to reinstall the existingapps/desktop/release/mac-arm64/Hermes.app, whose embedded stamp andapp.asarstill came from the old branch/ref.Verification
uv run pytest tests/hermes_cli/test_gui_command.py -qnpm run test:desktop:platforms --workspace apps/desktoppython3 -m py_compile hermes_cli/main.pygit diff --check origin/main..HEADUpstream
Upstream counterpart is included in NousResearch#39192.