Skip to content

fix(cli): accept launcher flags after dashboard command - #79

Merged
OmarB97 merged 1 commit into
mainfrom
fix/macos-desktop-backend-startup-fork
Jun 4, 2026
Merged

fix(cli): accept launcher flags after dashboard command#79
OmarB97 merged 1 commit into
mainfrom
fix/macos-desktop-backend-startup-fork

Conversation

@OmarB97

@OmarB97 OmarB97 commented Jun 4, 2026

Copy link
Copy Markdown
Owner

Summary

  • accept known global Hermes launcher flags when they are placed after the subcommand
  • cover the official desktop launch shape (dashboard ... --tui) so the backend does not exit before readiness

Root cause

The packaged macOS desktop app launches the backend as hermes dashboard --no-open ... --tui. --tui is a global option, but argparse only accepted it before the dashboard subcommand, so the backend exited with status 2 during desktop startup.

Validation

  • python -m pytest tests/hermes_cli/test_default_interface_resolution.py tests/hermes_cli/test_subparser_routing_fallback.py tests/hermes_cli/test_startup_plugin_gating.py -q
  • live ~/.hermes/hermes-agent cherry-pick ran the same focused tests
  • direct /api/status returned gateway_running=True, gateway_state=running
  • direct /api/ws probe opened and received gateway.ready
  • normal /Applications/Hermes.app relaunch opened past CONNECTING into the chat shell with backend command dashboard --no-open --tui --host 127.0.0.1 --port 9120

Related

@github-actions

github-actions Bot commented Jun 4, 2026

Copy link
Copy Markdown

🔎 Lint report: fix/macos-desktop-backend-startup-fork vs origin/main

ruff

Total: 0 on HEAD, 0 on base (➖ 0)

🆕 New issues: none

✅ Fixed issues: none

Unchanged: 0 pre-existing issues carried over.

ty (type checker)

Total: 9842 on HEAD, 9842 on base (➖ 0)

🆕 New issues: none

✅ Fixed issues: none

Unchanged: 5105 pre-existing issues carried over.

Diagnostics are surfaced as warnings — this check never fails the build.

@OmarB97
OmarB97 force-pushed the fix/macos-desktop-backend-startup-fork branch from 278cf92 to e7e4345 Compare June 4, 2026 14:30
@OmarB97
OmarB97 marked this pull request as ready for review June 4, 2026 14:46
@OmarB97
OmarB97 merged commit 0c2f9ca into main Jun 4, 2026
21 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants