fix(cli): accept launcher flags after dashboard command - #79
Merged
Conversation
🔎 Lint report:
|
OmarB97
force-pushed
the
fix/macos-desktop-backend-startup-fork
branch
from
June 4, 2026 14:30
278cf92 to
e7e4345
Compare
OmarB97
marked this pull request as ready for review
June 4, 2026 14:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dashboard ... --tui) so the backend does not exit before readinessRoot cause
The packaged macOS desktop app launches the backend as
hermes dashboard --no-open ... --tui.--tuiis a global option, but argparse only accepted it before thedashboardsubcommand, so the backend exited with status 2 during desktop startup.Validation
python -m pytest tests/hermes_cli/test_default_interface_resolution.py tests/hermes_cli/test_subparser_routing_fallback.py tests/hermes_cli/test_startup_plugin_gating.py -q~/.hermes/hermes-agentcherry-pick ran the same focused tests/api/statusreturnedgateway_running=True,gateway_state=running/api/wsprobe opened and receivedgateway.ready/Applications/Hermes.apprelaunch opened pastCONNECTINGinto the chat shell with backend commanddashboard --no-open --tui --host 127.0.0.1 --port 9120Related