fix(agent): defer background review during TUI turns - #60
Merged
Conversation
🔎 Lint report:
|
| Rule | Count |
|---|---|
unresolved-attribute |
3 |
First entries
tests/run_agent/test_background_review.py:146: [unresolved-attribute] unresolved-attribute: Unresolved attribute `_background_review_idle_delay_seconds` on type `AIAgent`
tests/run_agent/test_background_review.py:109: [unresolved-attribute] unresolved-attribute: Object of type `AIAgent` has no attribute `_foreground_turn_generation`
tests/run_agent/test_background_review.py:145: [unresolved-attribute] unresolved-attribute: Unresolved attribute `_foreground_turn_generation` on type `AIAgent`
✅ Fixed issues: none
Unchanged: 5000 pre-existing issues carried over.
Diagnostics are surfaced as warnings — this check never fails the build.
Owner
Author
|
Upstream PR: NousResearch#36187 This fork mirror replaces superseded PR #59, which conflicted because it was based from upstream/main instead of fork main. Live taro Hermes has also been patched and hermes-phone restarted so this can be exercised immediately. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Clean fork mirror for upstream PR NousResearch#36187. PR #59 was closed because it was based on upstream/main and conflicted with fork main; this replacement is based on fork main.
What changed
HERMES_BACKGROUND_REVIEW_IDLE_DELAY_SECONDSis configured.Verification
python3 -m py_compile run_agent.py agent/agent_init.py agent/conversation_loop.py agent/background_review.py tests/run_agent/test_background_review.pypython3 -m pytest -o addopts='' tests/run_agent/test_background_review.py tests/run_agent/test_background_review_cache_parity.py tests/run_agent/test_background_review_toolset_restriction.py tests/run_agent/test_codex_app_server_integration.py::TestRunConversationCodexPath::test_background_review_skill_trigger_fires_above_threshold tests/run_agent/test_codex_app_server_integration.py::TestRunConversationCodexPath::test_background_review_signature_never_breaks -qgit diff --checkUpstream
NousResearch#36187