Skip to content

fix: retry short incomplete dflash finals - #54

Merged
OmarB97 merged 1 commit into
mainfrom
fix/dflash-short-final-fragment-mirror
May 31, 2026
Merged

fix: retry short incomplete dflash finals#54
OmarB97 merged 1 commit into
mainfrom
fix/dflash-short-final-fragment-mirror

Conversation

@OmarB97

@OmarB97 OmarB97 commented May 31, 2026

Copy link
Copy Markdown
Owner

Summary

  • Treat short no-tool dflash finals ending on connector tails like and some as incomplete stalls.
  • Use the merged stall-retry config helper in the loop so configured retry lanes are honored.
  • Allow the retry lane to recover this short-fragment class with either a tool call or completed visible continuation.

Evidence

  • python3 -m pytest tests/agent/test_stall_retry.py -q -> 25 passed
  • python3 -m py_compile agent/stall_retry.py agent/conversation_loop.py
  • Live taro: .venv/bin/python -m pytest tests/agent/test_stall_retry.py -q -> 25 passed
  • Live TUI canary returned DETECTOR_OK after verifying the exact screenshot fragment.

Context

Replacement mirror for new work after fork PR #53 was already merged. Upstream PR: NousResearch#35642

@github-actions

Copy link
Copy Markdown

🔎 Lint report: fix/dflash-short-final-fragment-mirror vs origin/main

ruff

Total: 0 on HEAD, 0 on base (➖ 0)

🆕 New issues: none

✅ Fixed issues: none

Unchanged: 0 pre-existing issues carried over.

ty (type checker)

Total: 9620 on HEAD, 9620 on base (➖ 0)

🆕 New issues: none

✅ Fixed issues: none

Unchanged: 4999 pre-existing issues carried over.

Diagnostics are surfaced as warnings — this check never fails the build.

@OmarB97
OmarB97 merged commit 16f338e into main May 31, 2026
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant