test(gateway): stop TTS state leaking into later tests - #268
Merged
Conversation
OmarB97
added a commit
that referenced
this pull request
Jul 20, 2026
Co-authored-by: Omar Baradei <omar@kostudios.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
HERMES_VOICE_TTS=0with pytestmonkeypatchbefore exercising the runtime TTS toggle.Root cause
monkeypatch.delenv(..., raising=False)registers no undo when the key starts absent. The testedvoice.togglehandler then setsHERMES_VOICE_TTS=1, which leaked through the rest oftests/test_tui_gateway_server.py. A later fake completion containingpartial answer completeconsequently generated an MP3 and launched/usr/bin/afplayon the developer machine.Verification
scripts/run_tests.sh tests/test_tui_gateway_server.py -q -k "voice_toggle_tts_branch_also_carries_record_key or session_activate_returns_inflight_stream_before_completion"— 2 passed.afplayaudio events.Scope
One test-only environment setup line plus the explanatory comment.