Cross-port sUSDe batch script helpers - #275
Conversation
Cross-port of the multisig setup/env entry from feat/susde-aave-loop commit f75cf2f, renamed from yield multisig to Treasury Working Group.
📝 WalkthroughWalkthroughThe PR adds treasury working group multisig support and Safe transaction logging to the batch proposal infrastructure. It updates configuration to include a treasury working group address, adds conditional heartbeat validation skipping, introduces a new setup modifier for treasury working group owners, and logs Safe transaction details during proposal creation. Solidity compiler pragmas are also updated to >=0.8.24. ChangesTreasury Working Group & Safe Tx Logging
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/scripts/ops/ChangeKernelExecutor.s.sol`:
- Line 2: foundry.toml's global catch-all version constraint prevents the script
ChangeKernelExecutor.s.sol (which uses pragma >=0.8.24) from compiling; update
foundry.toml by inserting a specific compilation restriction for that script
(targeting solidity 0.8.24) before the existing catch-all entry so the script's
pragma is satisfied and the global { paths = "**", version = "0.8.15" } still
applies to everything else.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 07919efd-88c1-433e-be67-27d1e7eadc03
📒 Files selected for processing (5)
.gitignoresrc/scripts/env.jsonsrc/scripts/ops/ChangeKernelExecutor.s.solsrc/scripts/ops/lib/BatchScriptV2.solsrc/test/proposals/OIP_194A.t.sol
Summary
feat/susde-aave-loopwithout bringing over the full sUSDe Aave loop implementation..pnpm-store/to.gitignore.setUpWithTreasuryWorkingGroupMSandolympus.multisig.treasuryWorkingGroup.BatchScriptV2.ChangeKernelExecutor.s.solandOIP_194A.t.solto meet the current Solidity baseline.Source commits
f75cf2f91f38523880ef972d057Validation
pnpm installpnpm run buildpnpm exec prettier --write src/scripts/ops/lib/BatchScriptV2.sol src/scripts/env.jsonpnpm exec solhint --config ./.solhint.json src/scripts/ops/lib/BatchScriptV2.solforge build --contracts src/scripts/ops/ChangeKernelExecutor.s.solforge build --contracts src/test/proposals/OIP_194A.t.solpnpm run lintcompleted successfully with existing Solhint warnings only; no tracked files changed.Summary by CodeRabbit
New Features
Chores