Release: V1 Migrator for OHM v1→v2 migration, emergency shutdown improvements, and developer tooling by 0xJem · Pull Request #218 · OlympusDAO/olympus-v3

0xJem · 2026-03-10T13:18:47Z

Summary

Introduces the V1 Migrator policy enabling OHM v1 holders to migrate to OHM v2 via merkle drop, plus
emergency shutdown improvements and enhanced developer tooling.

Key Changes

V1 Migrator (#196)

New V1Migrator policy with merkle-based OHM v1 → v2 migration
Migration cap governance control via setRemainingMintApproval()
Mainnet deployment scripts and OCG proposal
previewMigrate() view helper for users
rescue() function for recovering accidentally sent tokens
Guards against griefing and duplicate merkle root setting

Emergency Shutdown (#183)

Centralized emergency-config.json with JSON schema validation
GitHub workflow to automatically validate emergency config
Improved update-emergency-config skill using jq and contract sources

Developer Tooling (#195, #197)

New Claude skills: /test-write, /test-debug, /lint-fix
AGENTS.md with comprehensive project guidance
MCP server configuration (CodeRabbit, Context7, Etherscan, GitHub)

Other Changes

Burner policy: Added PolicyEnabler, IVersioned, IERC165 support
OlyBatch: Tenderly sender fixes, anvil fork support
Fork testing documentation improvements

Summary by CodeRabbit

Release Notes

New Features
- Added OHM V1-to-V2 migration capability with merkle-verified eligibility and mint approval caps
- Introduced emergency shutdown configuration system with validation and documentation
- Added Anvil fork testing support for proposal execution and local testing workflows
Documentation
- Comprehensive emergency shutdown procedures and configuration schemas
- V1 migrator user guide and technical specifications
- Local fork testing and staking replacement documentation
Developer Experience
- Enhanced testing infrastructure with validation helpers and fork utilities
- Improved CI/CD workflows with emergency config validation
- New governance proposal execution tools for local and testnet environments

Agent/LLM docs

…posal and MS batch

…l migration

… add relevant values to errors

…nal token migrator

…e enable function

…loyment/setup

- Restrict contract mode to .sol files under src/policies/ or src/periphery/ - Add path validation in B1 to reject contracts outside valid directories - Update mode detection to explicitly define error case for invalid paths - Remove fallback logic that attempted to resolve unknown contract keys

- Enumerate concrete contract declarations instead of file-level grep - Walk inheritance chain up to 3 levels to detect indirect inheritance - Skip only abstract contract declarations, not entire files containing abstract contracts - Track and report inheritance level (direct vs indirect) for detected enablers - Properly handle cases like BaseDepositFacility -> PolicyEnabler

- Explain that /update-emergency-config is a Claude Code skill - Document its capabilities: scan, generate, validate, and update - Add example usage for both scan mode and contract mode - Clarify access location (repository's Claude Code environment)

- Add ajv dependency for JSON schema validation - Validate config against emergency-config.schema.json (previously loaded but unused) - Remove $schema property before validation to avoid meta-schema issues - Use validateFormats: false since dates/URLs are validated by custom validators - Log schema validation errors and abort on failure Fixes issue where schema was loaded but never used for validation.

- Check that call.function exists in the ABI definition (call.abi) - Look up ABI definition from abis[call.abi] after confirming key exists - Search for matching function name in ABI array using abiDef.some() - Report clear error when function is missing from ABI - Maintains original unknown-ABI error when abiDef is undefined This catches typos and wrong function names in calldata definitions during CI.

- Add pnpm setup and installation steps - Add pnpm cache for faster workflow runs - Install dependencies with pnpm install --frozen-lockfile - Fixes "Cannot find module 'ajv'" error in CI The ajv package was added for JSON schema validation but the CI workflow wasn't installing dependencies before running the validation script.

Improved Emergency Scripts

- CoolerV2: 0x19b7... → 0x8bEB... - CoolerV2Composites: 0xe7A8... → 0x992e... - EmissionManager: 0x8478... → 0x79cF...

…oyment Replace staking contracts on Sepolia to correct sOHM index

coderabbitai · 2026-03-10T13:19:23Z

Caution

Review failed

Pull request was closed or merged during review

📝 Walkthrough

Walkthrough

This PR introduces OHM v1-to-v2 migration infrastructure via merkle-verified eligibility, adds comprehensive emergency shutdown documentation and validation tooling, updates operational scripts to support chain-based parameter resolution, refactors GitHub Actions workflows with consolidated dependency installation, and adds extensive LLM/agent guidance and Claude skills documentation.

Changes

Cohort / File(s)	Summary
V1 Migration Contracts `src/external/OwnedERC20.sol`, `src/policies/V1Migrator.sol`, `src/policies/Burner.sol`, `src/policies/interfaces/IV1Migrator.sol`, `src/proposals/MigrationProposal.sol`, `src/proposals/MigrationProposalHelper.sol`	New migration policy infrastructure: OwnedERC20 (owner-controlled minting), V1Migrator (merkle-gated eligibility with nonce-based cap management), Burner (token burning with category tracking), MigrationProposal (multi-step governance activation), and MigrationProposalHelper (one-time migration orchestration).
Legacy Contract Interfaces `src/interfaces/IOlympusTokenMigrator.sol`, `src/interfaces/IOlympusTreasury.sol`, `src/interfaces/IStaking.sol`, `src/interfaces/IgOHM.sol`, `src/interfaces/IsOHM.sol`	New interfaces for v1 token migration, treasury management, staking contracts with getter expansion (OHM, sOHM, gOHM addresses, index, supply), and legacy contract compatibility.
V1 Migration Tests `src/test/policies/V1Migrator/*`, `src/test/proposals/MigrationProposal.t.sol`, `src/test/proposals/MigrationProposalHelperFork.t.sol`	Comprehensive test suites covering merkle verification, migration flows, access control, edge cases (cap reached, insufficient approval, invalid proofs), integration tests, and fork-based validation against mainnet state.
Deployment & Operations `src/scripts/deploy/DeployV3.s.sol`, `src/scripts/ops/batches/MigrationProposalSetup.sol`, `src/scripts/ops/batches/V1MigratorConfig.sol`, `src/scripts/ops/ReplaceStaking.s.sol`, `src/scripts/ops/VerifyLegacyStaking.s.sol`	New deployment functions for migration contracts, batch scripts orchestrating multi-step activation/configuration with post-batch validation, and legacy staking replacement/verification workflows.
Operational Script Updates `shell/mint/.sh`, `shell/roles/.sh`, `shell/safeBatch.sh`, `shell/safeBatchV2.sh`, `src/scripts/ops/Minter.s.sol`, `src/scripts/ops/Roles.s.sol`	Refactored to derive chain from block.chainid and load environment dynamically; removed explicit RPC_URL/CHAIN dependencies in favor of --chain/--ledger parameters; added Anvil fork support and Ledger signing workflow.
GitHub Actions & CI `.github/workflows/*.yml`, `foundry.toml`, `package.json`, `remappings.txt`	Consolidated dependency installation steps with explicit pnpm install and build stages; updated safe-utils (0.0.13→0.0.17) and solidity-http (0.0.6→0.0.7) dependencies; added multisig profile; refactored npm scripts for expanded glob patterns and new anvil:fork command.
Emergency Shutdown Infrastructure `documentation/emergency/EMERGENCY_SHUTDOWN.md`, `documentation/emergency/emergency-config.json`, `documentation/emergency/emergency-config.schema.json`, `documentation/emergency/emergency-abis.json`, `.github/workflows/validate-emergency-config.yml`, `shell/validate-emergency-config.js`	Comprehensive emergency configuration system: schema-validated JSON structure defining per-chain emergency multisigs, contract addresses, and parameterized shutdown procedures; validation script with integrity checks (semver, ABI references, component coverage); automated CI workflow with uncommitted-changes detection.
Proposal Execution Updates `src/proposals/ProposalScript.sol`, `src/scripts/proposals/executeOn*.sh`, `src/scripts/proposals/submitProposal.sh`, `src/scripts/proposals/printInputs.sh`, `src/scripts/ops/OlyBatch.sol`, `src/scripts/ops/lib/BatchScriptV2.sol`	Added Anvil fork execution path alongside Tenderly; refactored proposal scripts to use consolidated argument loading and chain-based RPC; enhanced BatchScriptV2 with post-batch validation selectors, fork-mode dispatching, and snapshot-based simulation.
LLM/Agent Guidance & Configuration `AGENTS.md`, `CLAUDE.md`, `.claude/commands/update-emergency-config.md`, `.claude/skills/lint-fix/SKILL.md`, `.claude/skills/test-debug/SKILL.md`, `.claude/skills/test-write/SKILL.md`, `.claude/skills/test-write/SAMPLE_TEST.md`, `.mcp.json`, `.gitignore`	Comprehensive agent guidelines covering project overview, development workflow, testing disciplines, safety/permissions, code standards, and tool usage; skill definitions for emergency config updates, linting, testing, and debugging; MCP server configuration for GitHub/Etherscan/Context7 integration; updated .gitignore to track .claude/ and agent documentation.
Environment & Deployment Config `src/scripts/env.json`, `deployments/.mainnet-*.json`, `src/scripts/deploy/savedDeployments/v1_migrator.json`, `src/proposals/addresses.json`, `conductor.json`	Added tempOHM, legacy OHMv1, migration contracts, and updated staking/treasury addresses; saved deployment manifests and script addresses for migration contracts; new conductor.json with test/setup scripts.
Documentation `audit/2026-01_v1-migrator/README.md`, `documentation/V1_MIGRATOR.md`, `documentation/FORK.md`, `src/scripts/DEPLOY_TESTNET.md`, `src/scripts/REPLACE_STAKING.md`, `src/scripts/ops/README.md`	Audit documentation detailing V1Migrator architecture, merkle verification, and governance flow; user-facing V1Migrator guide; fork testing workflow; testnet deployment and staking-replacement procedures; updated ops README for new --function/--fork/--ledger workflow.
Test Infrastructure & Mocks `src/test/mocks/MockGohm.sol`, `src/test/mocks/MockStakingForZD.sol`, `src/test/external/ClaimTransfer.t.sol`, `src/test/policies/Burner.t.sol`, `src/test/policies/EmissionManager.t.sol`, `src/test/policies/pOLY.t.sol`	Updated MockGohm with mutable index and setter; added staking interface stubs; expanded test scaffolding for Burner with disabled-state tests; added sOHM getter to mock contracts for interface alignment.
Anvil Utilities `shell/anvil/deal_gohm.sh`, `shell/anvil/warp.sh`	New shell utilities for local fork testing: deal_gohm automates gOHM distribution and voting delegation; warp mines blocks on Anvil.
Postinstall & Build `shell/postinstall.sh`, `README.md`	Removed dependency installation from postinstall (now handled in workflows); updated README with explicit pnpm install and forge/pnpm build instructions.

Estimated code review effort

🎯 5 (Critical) | ⏱️ ~120 minutes

Possibly related PRs

OHM v1 Migrator: Defund OHM v1 TokenMigrator, introduce V1Migrator #196: Adds identical migration-related contracts (V1Migrator, Burner, MigrationProposal, OwnedERC20), deployment functions, and test suites.
feat: add centralized emergency shutdown config #198: Modifies the same emergency configuration artifacts (emergency-config.json, emergency-abis.json, schema, validation script, and CI workflow).
Agent/LLM docs #195: Introduces the same AGENTS.md, CLAUDE.md, and .gitignore changes for LLM documentation tracking.

Poem

🐰 A rabbit hops through migration paths so grand,
Where v1 meets v2 in merkle-tree command;
Emergency configs keep the protocol sound,
While agents guide scripting on every ground!
From Anvil to Tenderly, fork tests run free—
This refactor's a feast, hoppy coding spree! 🥕

✨ Finishing Touches

📝 Generate docstrings (stacked PR)
📝 Generate docstrings (commit on current branch)

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch develop

0xJem and others added 30 commits January 12, 2026 17:44

Add airdrop of gOHM to OHMv1 holders

54bd0e4

Add AGENTS.md

8dde051

Tweaks

b9c73d7

Document agent behaviours

b606f2c

fix: typos

95e8d4e

docs(AGENTS.md): details of suggested git commit messages

9c27249

chore: linting

fa6a45e

docs(AGENTS.md): add suggested use of git worktree

ff895c3

docs(AGENTS.md): tweaks

e89bc19

Merge pull request #195 from OlympusDAO/feature/agent-docs

f6e654e

Agent/LLM docs

Merge branch 'develop' into feature/migrator-burn

91afd51

Merge branch 'master' into feature/migrator-burn

6a0d883

docs(AGENTS.md): add notes on common mix-ins and interfaces

f51eda8

feat: policy to allow for OHM v1 -> v2 migration, clean up of OCG pro…

d0252e1

…posal and MS batch

docs(AGENTS.md): import behaviour

ee8b200

test: split LegacyMigrator tests into per-function test files

3ec9a97

test: shift tests to use modifiers, improve test coverage

ae2a7b9

feat: improve test coverage, re-arrange tests, add support for partia…

e18bdb3

…l migration

fix: simplify state management with MINTR approval and migration cap,…

b8e2c8a

… add relevant values to errors

deps: bump safe-utils to 0.0.17 (and related dependencies)

7f46344

fix: OHM v1 to v2 conversion rate using the same process as the origi…

4f97301

…nal token migrator

fix: ensure that the OHM v2 amount is not zero

c9822cd

test: add fork test for migration without mocks

f4f1488

refactor: set the merkle root in the constructor, migration cap in th…

4669f03

…e enable function

refactor: shift ILegacyMigrator into correct directory

a00207b

refactor: remove airdrop from MigrationHelper contract

e33e67b

fix: extract OwnedERC20 contract and treasury/migrator interfaces

26e6659

fix: rename MigrationHelper to MigrationProposalHelper

3ce10cc

test: update MigrationProposal test to handle different stages of dep…

61e8da7

…loyment/setup

chore: linting

c0ae3e6

0xJem and others added 23 commits March 10, 2026 14:18

chore: linting

c18153e

docs: fix typo

967864e

script: improve validation

c4fc7fa

script: remove obsolete emergency scripts, update docs

2379077

chore: linting

2a0d627

chore: correct ABI

c1ea34f

chore: nitpicks

815e9cd

chore: add missing definition for CD LimitOrders

68056fa

script: format files after config

e5a4a80

chore: linting

830906a

script: tweaks to validation workflow

1acaee3

chore: missing tool

4175b49

Merge pull request #183 from OlympusDAO/emergency

1485bfc

Improved Emergency Scripts

Merge branch 'develop' into opencode/eager-forest

effdca2

chore: consistent naming of Cooler Composites key

769a1b7

fix(docs): align sepolia addresses with env.json

85a9b2b

- CoolerV2: 0x19b7... → 0x8bEB... - CoolerV2Composites: 0xe7A8... → 0x992e... - EmissionManager: 0x8478... → 0x79cF...

Merge pull request #215 from OlympusDAO/origin/feature/sepolia-redepl…

2979cfc

…oyment Replace staking contracts on Sepolia to correct sOHM index

0xJem self-assigned this Mar 10, 2026

0xJem merged commit 916a753 into master Mar 10, 2026
9 of 10 checks passed

This was referenced Mar 26, 2026

Improve shutdown detection in the emergency-config.json #224

Merged

chore(ci): standardize pnpm-only workflows and guard installs #226

Merged

coderabbitai Bot mentioned this pull request Apr 6, 2026

chore: hardening baseline before Dependabot remediation #227

Merged

coderabbitai Bot mentioned this pull request Jul 13, 2026

Add CCIP token pool rate limit batch #286

Merged

Navigation Menu

Release: V1 Migrator for OHM v1→v2 migration, emergency shutdown improvements, and developer tooling - #218

Release: V1 Migrator for OHM v1→v2 migration, emergency shutdown improvements, and developer tooling#218
0xJem merged 285 commits into
masterfrom
develop

0xJem commented Mar 10, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Mar 10, 2026 •

edited

Loading

Review failed

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Poem

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

0xJem commented Mar 10, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Key Changes

V1 Migrator (#196)

Emergency Shutdown (#183)

Developer Tooling (#195, #197)

Other Changes

Summary by CodeRabbit

Release Notes

Uh oh!

coderabbitai Bot commented Mar 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review failed

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Poem

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

0xJem commented Mar 10, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Mar 10, 2026 •

edited

Loading