Skip to content
This repository has been archived by the owner on May 17, 2021. It is now read-only.

Missing removeAllListeners() #58

Closed
Rush opened this issue Sep 5, 2013 · 5 comments
Closed

Missing removeAllListeners() #58

Rush opened this issue Sep 5, 2013 · 5 comments

Comments

@Rush
Copy link

Rush commented Sep 5, 2013

removeAllListeners() is necessary to clean up an object.

@Olical
Copy link
Owner

Olical commented Sep 5, 2013

It may not be clear enough, but removeEvent will remove everything if you don't pass any arguments.

@nathggns
Copy link
Contributor

nathggns commented Sep 5, 2013

Is this the same as the Node API for it?

Sent from my iPhone

On 5 Sep 2013, at 16:32, Oliver Caldwell [email protected] wrote:

It may not be clear enough, but removeEvent will remove everything if you don't pass any arguments.


Reply to this email directly or view it on GitHub.

@Olical
Copy link
Owner

Olical commented Sep 5, 2013

Node has removeAllListeners, it works in the exact same way as my removeEvent.

@Rush
Copy link
Author

Rush commented Sep 5, 2013

Thanks, looks like it might be beneficial to have removeAllListeners() anyway, for the sake of people used to Node.JS API.

@nathggns
Copy link
Contributor

nathggns commented Sep 5, 2013

I agree. Sticking with Node's API as closely as possible is vital.

Sent from my iPhone

On 5 Sep 2013, at 17:45, RushPL [email protected] wrote:

Thanks, looks like it might be beneficial to have removeAllListeners() anyway, for the sake of people used to Node.JS API.


Reply to this email directly or view it on GitHub.

Olical added a commit that referenced this issue Sep 22, 2013
Also added a quick test of it.
@Olical Olical closed this as completed Sep 22, 2013
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants