Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #122 #123

Merged
merged 4 commits into from
Jan 2, 2024
Merged

fix #122 #123

merged 4 commits into from
Jan 2, 2024

Conversation

ChristophCaina
Copy link
Contributor

@ChristophCaina ChristophCaina commented Dec 28, 2023

This should fix reported issue #122

This PR caused another issue:

Logger: homeassistant.components.sensor
Source: helpers/entity_platform.py:360
Integration: Sensor (documentation, issues)
First occurred: 2:43:34 PM (8 occurrences)
Last logged: 2:43:34 PM

Error while setting up plant platform for sensor
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 360, in _async_setup_platform
    await asyncio.shield(task)
  File "/config/custom_components/plant/sensor.py", line 125, in async_setup_entry
    pintegral = PlantTotalLightIntegral(hass, entry, pcurppfd, plant)
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/config/custom_components/plant/sensor.py", line 540, in __init__
    unit_time=UnitOfTime.Seconds,
              ^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/enum.py", line 784, in __getattr__
    raise AttributeError(name) from None
AttributeError: Seconds

Not sure, what I need to change here... to fix this error :-(

[update]
this error should also be fixed

This should fix reported issue #122
fix depricated TEMP_*** constant
@Olen
Copy link
Owner

Olen commented Dec 29, 2023

Thanks

I have not been able to test 2024 yet.
Please tell me when you are sure all warnings have been taken care of, and I will make a new release.

@ChristophCaina
Copy link
Contributor Author

Hi,
at least - I don't see any warnings in my logs anymore... :)

The above error should also be fixed with the latest changes, since I had a typo in one of the previous changes.

@hmmbob
Copy link
Contributor

hmmbob commented Dec 31, 2023

There are more (see also #124).

@ChristophCaina Please also have a look at plant_meters.py for another occurrence of TIME_SECONDS, while plant_thresholds.py has the CELSIUS and FAHRENHEITS as well

@ChristophCaina
Copy link
Contributor Author

Oh... strange - this wasn't shown in my logs...
I'll add them, too... thanks :) 👍

@ChristophCaina
Copy link
Contributor Author

should be fixed with PR's #125 and #126

@Olen
Copy link
Owner

Olen commented Jan 2, 2024

Thanks again.
I'll merge these and release a new beta.

@Olen Olen merged commit e76df78 into Olen:master Jan 2, 2024
3 checks passed
@hmmbob
Copy link
Contributor

hmmbob commented Jan 2, 2024

Just reporting that beta runs fine and errors are gone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants