Skip to content

Fix tweakers.net #10830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 7, 2024
Merged

Fix tweakers.net #10830

merged 3 commits into from
Jan 7, 2024

Conversation

claudiodekker
Copy link
Contributor

Fixes #5637

Remove trailing comma
@OhMyGuus
Copy link
Owner

OhMyGuus commented Jan 6, 2024

Disabling all, cookies on tweakers will break a lot of articles. This is the reason that "Ingesloten content van derden
" is clicked & enabled on tweakers.
image

@claudiodekker
Copy link
Contributor Author

claudiodekker commented Jan 6, 2024

Ah, I wasn't aware of this, and instead expected them to place the functionally required cookies with reject all. I'll re-adjust it in a bit!

@claudiodekker
Copy link
Contributor Author

claudiodekker commented Jan 6, 2024

Alright, I've reverted the changes, and have wrapped the "ingesloten content van derden" switch in an optional call.

It took me a while to understand, but I believe the reason that the issue occurred has to do with that Tweakers by default already has these flags enabled, and because of that, the script isn't able to toggle any flags and just stops.

(The way I've verified this, is by adding an additional flag (.koekie_bar .relevantAds .notSelect.toggleSwitch) to purposefully enable the "Relevantere advertenties" flag, and by moving this up and down the stack until it started breaking.)

@OhMyGuus
Copy link
Owner

OhMyGuus commented Jan 7, 2024

Thanks 👍

@OhMyGuus OhMyGuus merged commit c4a2d15 into OhMyGuus:master Jan 7, 2024
@claudiodekker claudiodekker deleted the tweakers branch January 8, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[REQ] tweakers.net
2 participants