Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zip file seems to be corrupted #3

Closed
felixZmn opened this issue Sep 16, 2022 · 10 comments
Closed

zip file seems to be corrupted #3

felixZmn opened this issue Sep 16, 2022 · 10 comments

Comments

@felixZmn
Copy link

The installation in Firefox fails with the error Message “This add-on could not be installed because it appears to be corrupt”. In Chrome, the zip can be installed, but there is a deprecation warning for manifest version 2.

@Avtpp
Copy link

Avtpp commented Sep 16, 2022

The installation in Firefox fails with the error Message “This add-on could not be installed because it appears to be corrupt”. In Chrome, the zip can be installed, but there is a deprecation warning for manifest version 2.

Same error message for me on Librewolf (Firefox).

@winskil
Copy link
Contributor

winskil commented Sep 16, 2022

Ran the source code through https://addons.mozilla.org/en-GB/developers/addon/submit/distribution and it created an XPI file which works. So it needs to be signed in order to work.

@DAC324
Copy link

DAC324 commented Sep 16, 2022

Ran the source code through https://addons.mozilla.org/en-GB/developers/addon/submit/distribution and it created an XPI file which works. So it needs to be signed in order to work.

Can you explain which steps are required to create that working XPI file?

@winskil
Copy link
Contributor

winskil commented Sep 16, 2022

Ran the source code through https://addons.mozilla.org/en-GB/developers/addon/submit/distribution and it created an XPI file which works. So it needs to be signed in order to work.

Can you explain which steps are required to create that working XPI file?

@DAC324 I just logged into the developer hub, clicked on Submit new extension and followed the instructions.
It creates the signed extension in a few minutes.

Edit: Note that this only works for Firefox. The steps for Chrome Web Store are different and you have to pay $5 fee.

@DAC324
Copy link

DAC324 commented Sep 16, 2022

I just logged into the developer hub, clicked on Submit new extension and followed the instructions.
It creates the signed extension in a few minutes.

This does not seem to work for me. I uploaded IDAC.zip "for my own", it validates OK but then I am presented with the following:


Submit a New Add-on
Do You Need to Submit Source Code?

Mozilla’s add-on reviewers need to be able to read and reproduce the code in your extension. If they can’t, your extension may be rejected.

Do you use any of the following in your extension?

    Code generators or minifiers
    Tools that combine multiple files into a single file, such as webpack
    Web template engines, both for HTML and CSS
    Any other tool that takes code or files, applies processing, and generates code or file(s) to include in the extension

Yes No

What am I supposed to do here?

Update #1: Looks like I can safely tick "No"here. But I am still unable to find any XPI there.
Update #2: This takes some time. Usually, you get an e-mail notification once the XPI is ready. You can then get it using the link provided in the mail, and clicking on the version number displayed there.

@OhMyGuus
Copy link
Owner

    1. Already working on migrating the Manifest from V2 to Manifest V3, still need some testing for it but should be working soon.
    1. Thanks for the report, I didn't have time yesterday anymore to test it on firefox but going to do that now and see if I can update the action to generate the XPI archive as well.

@winskil
Copy link
Contributor

winskil commented Sep 16, 2022

@DAC324
Screenshot 2022-09-16 at 14 24 42
Screenshot 2022-09-16 at 14 23 52

@Hermit8947
Copy link

    1. Already working on migrating the Manifest from V2 to Manifest V3, still need some testing for it but should be working soon.
      1. Thanks for the report, I didn't have time yesterday anymore to test it on firefox but going to do that now and see if I can update the action to generate the XPI archive as well.

thx, for your work, mate!

@DAC324
Copy link

DAC324 commented Sep 16, 2022

For all those who do not have a Firefox account:
https://userupload.net/t5oi2ir03szm

@OhMyGuus
Copy link
Owner

OhMyGuus commented Sep 16, 2022

https://github.com/OhMyGuus/I-Dont-Care-About-Cookies/releases/tag/IDCAC_2022.09.16_15_00
The latest release has now a working IDCAC_firefox.xpi generated using Github actions

Thank u all for the report & the steps

OhMyGuus added a commit that referenced this issue Oct 15, 2022
* Support for maisonstandards.com closes #96

* Support for notify.events fixes #99

* Support for pricewise.nl fixes #104

* Support for apotheke-villingen.de closes #103

* Added support for hu-manity banners fixes #107

* Support for pngwebicons.com closes #110

* Support for lokalplus.nrw closes #113

* support for passadena.gr closes #112

* Support for cleantalk.org closes #115

* Fix for gray backgrounds on some sites
obfuscated-loop pushed a commit that referenced this issue Jun 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants