Add support for Node 10 #7264
Add support for Node 10 #7264
Conversation
| * for your repo. | ||
| */ | ||
| "nodeSupportedVersionRange": ">=8.0.0 <10.0.0", | ||
| "nodeSupportedVersionRange": ">=8.0.0 <9.0.0 || >=10.0.0 <11.0.0", |
There was a problem hiding this comment.
For node 10, maybe restrict it to more recent versions...
There was a problem hiding this comment.
or... do you know of problems with some versions?
There was a problem hiding this comment.
What do you think a good start version would be? I'm not sure how to determine that.
There was a problem hiding this comment.
A good version to start is the version that Node 10 first went LTS on. But I otherwise think 10.9.0 is a good starting place.
@dzearing I don't know of a specific problem, but @pgonzal really did not like to be on Node 10 initially because his perception (I believe) is that the very early versions of Node 10 are quite unstable ... and hence we generally stay at LTS.
There was a problem hiding this comment.
gotcha; maybe just start at the current LTS then? (10.14.1) as we're just starting to test now.
There were a few security updates recommending minbar 10.14.0, and the .1 patch was specifcally for windows msi issues.
https://nodejs.org/en/blog/vulnerability/november-2018-security-releases/
There was a problem hiding this comment.
What do you think a good start version would be? I'm not sure how to determine that.
(1) an LTS version, and (2) something you've actually tested yourself.
It is super frustrating to waste an hour investigating somebody's issue, only to find out that it was just a buggy build of NodeJS. We got burned by this repeatedly until we finally started insisting on LTS versions.
There was a problem hiding this comment.
Looked up when 8 and 10 became LTS, and it was at 8.9.0 and 10.9.0. (Didn't know until today that each even-numbered major version is out for about 6 months before becoming officially LTS.)
@pgonzal, I'm curious what types of problems you've run into due to buggy Node builds? I don't remember encountering any issues like that myself, though I'm sure it's possible.
There was a problem hiding this comment.
Recommended DL https://groups.google.com/forum/#!forum/nodejs-sec
5 participants
Pull request checklist
$ npm run changeDescription of changes
Node 10 is now LTS, so we should support it in Fabric. We will also continue to support Node 8 for now.
Scripts to test
Checked items work; unchecked items are broken or untested.
Microsoft Reviewers: Open in CodeFlow