This repository has been archived by the owner on Mar 26, 2019. It is now read-only.
MessageBanner: Make both hide and show public #322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
_hidebanner is private method not public As public should be hideBanner() not private _hideBanner() Renamed methods as no other component included component name in their public methods
|
This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request. |
mikewheaton
changed the title
mikewheaton
changed the title
mikewheaton
suggested changes
Jun 3, 2017
| @@ -144,7 +144,7 @@ namespace fabric { | |||
| /** | |||
| * hides banner when close button is clicked | |||
| */ | |||
| private _hideBanner(): void { | |||
| public _hide(): void { | |||
There was a problem hiding this comment.
Please remove the underscore (hide() not _hide()) and move this code under the show() function.
Removed white spaces as per gulp warnings. Updated event handler method name in _setListners with new method name 'hide', was '_hide'
Reinstated showBanner() as deprecated method, as not to break existing dep. Calls new method show()
mikewheaton
approved these changes
Jun 5, 2017
|
Approved |
…> tags Update HB/Docs & Test fix for GitHub .md files all showing <script> tags at bottom of all .md pages
… <script> tags" This reverts commit 3be0502.
Update HB/Docs & Test fix for GitHub .md files showing <script> tags at bottom of all .md pages on github site and also tested with two online editors and they also show <script> as plain text
Button , Callout, CheckBox, ChoiceFieldGroup, CommandBar,CommandButton, ContextualMenu, Dialog & MessageBanner
Decoded html encoded strings back to tags. FacePile.md still needs work
Edited all components MD Note: Dialog Component MD needing help to fix broken Button layout
Found format error
|
@PRIMETSS, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request. |
|
Approved 🎉 Thanks for all the fixes & contributions, @PRIMETSS!! |
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_hidebanner is private method not public
As public should be hideBanner() not private _hideBanner()
Renamed methods as no other component included component name in their
public methods