Skip to content

Conversation

@greysteil
Copy link
Contributor

Change Description:

Aligns return value for load with that used in production (i.e., return the object).

  1. Do these changes impact command syntax of any of the packages? (e.g., add/remove command, add/remove a command parameter, or update required parameters)

No.

  1. Do these changes impact documentation? (e.g., a tutorial on https://learn.microsoft.com/office/dev/add-ins/overview/office-add-ins)

No.

If you answered yes to any of these please do the following:
> Include 'Rick-Kirkham' in the review
> Make sure the README file is correct

Validation/testing performed:

Wrote a test. Tested manually

@greysteil greysteil requested a review from a team as a code owner May 1, 2024 18:28
@greysteil
Copy link
Contributor Author

@millerds looks like you're the most active merging PRs. This is a tiny change, but brings the mocks into better alignment with the real API. Hopefully it's an easy review, but let me know if anything's unclear. :octocat:

@millerds
Copy link
Collaborator

millerds commented May 1, 2024

/azurepipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@millerds
Copy link
Collaborator

millerds commented May 1, 2024

Thanks for your contribution!

@millerds millerds merged commit b7825fe into OfficeDev:master May 1, 2024
@greysteil greysteil deleted the return-object-from-load branch May 1, 2024 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants