[Outlook] - NAA sample with IE fallback #860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexJerabek
requested changes
Sep 30, 2024
| ### Create an application registration | ||
|
|
||
| 1. Go to the [Azure portal - App registrations](https://go.microsoft.com/fwlink/?linkid=2083908) page to register your app. | ||
| 1. Sign in with the **_admin_** credentials to your Microsoft 365 tenancy. For example, **[email protected]**. |
There was a problem hiding this comment.
Not sure how this example helps clarify "admin".
There was a problem hiding this comment.
not sure I understand the comment, but this matches existing Outlook-Add-in-SSO-NAA sample. It doesn't require admin to create the registration, but it does require it to consent to files.read scope.
There was a problem hiding this comment.
I read this sentence as "Sign in with your admin account (e.g.: [email protected])." I'm not sure why the email address help clarify anything. Guess this is more of a general question for @davidchesnut across all the samples. Please leave it as is.
Samples/auth/Outlook-Add-in-SSO-NAA-IE/src/taskpane/fallback/dialog.html
Outdated
Show resolved
Hide resolved
Co-authored-by: Alex Jerabek <[email protected]>
Co-authored-by: Alex Jerabek <[email protected]>
Co-authored-by: Alex Jerabek <[email protected]>
Co-authored-by: Alex Jerabek <[email protected]>
…ialog.html Co-authored-by: Alex Jerabek <[email protected]>
Co-authored-by: Alex Jerabek <[email protected]>
Co-authored-by: Alex Jerabek <[email protected]>
AlexJerabek
approved these changes
Oct 1, 2024
Co-authored-by: Alex Jerabek <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this Pull Request?
This adds a new sample that is similar to Outlook-Add-in-SSO-NAA, but has support for Internet Explorer (IE) fallback. IE fallback sample may not be for every app developer as it adds overhead of supporting multiple auth libraries and polyfills, but can be used as a reference if your add-in must support IE environments.