Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Outlook] - NAA sample with IE fallback #860

Merged
merged 25 commits into from
Oct 1, 2024
Merged

[Outlook] - NAA sample with IE fallback #860

merged 25 commits into from
Oct 1, 2024

Conversation

codexeon
Copy link
Collaborator

Q A
Bug fix? no
New feature? no
New sample? yes
Related issues? NA

What's in this Pull Request?

This adds a new sample that is similar to Outlook-Add-in-SSO-NAA, but has support for Internet Explorer (IE) fallback. IE fallback sample may not be for every app developer as it adds overhead of supporting multiple auth libraries and polyfills, but can be used as a reference if your add-in must support IE environments.

Copy link
Collaborator

@AlexJerabek AlexJerabek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sample looks good. This is mostly a copy edit on the readme. Has someone else tested the IE11 fallback path?

Samples/auth/Outlook-Add-in-SSO-NAA-IE/README.md Outdated Show resolved Hide resolved
Samples/auth/Outlook-Add-in-SSO-NAA-IE/README.md Outdated Show resolved Hide resolved
Samples/auth/Outlook-Add-in-SSO-NAA-IE/README.md Outdated Show resolved Hide resolved
### Create an application registration

1. Go to the [Azure portal - App registrations](https://go.microsoft.com/fwlink/?linkid=2083908) page to register your app.
1. Sign in with the **_admin_** credentials to your Microsoft 365 tenancy. For example, **[email protected]**.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how this example helps clarify "admin".

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure I understand the comment, but this matches existing Outlook-Add-in-SSO-NAA sample. It doesn't require admin to create the registration, but it does require it to consent to files.read scope.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I read this sentence as "Sign in with your admin account (e.g.: [email protected])." I'm not sure why the email address help clarify anything. Guess this is more of a general question for @davidchesnut across all the samples. Please leave it as is.

Samples/auth/Outlook-Add-in-SSO-NAA-IE/README.md Outdated Show resolved Hide resolved
Samples/auth/Outlook-Add-in-SSO-NAA-IE/assets/sample.json Outdated Show resolved Hide resolved
Samples/auth/Outlook-Add-in-SSO-NAA-IE/README.md Outdated Show resolved Hide resolved
Samples/auth/Outlook-Add-in-SSO-NAA-IE/assets/sample.json Outdated Show resolved Hide resolved
Samples/auth/Outlook-Add-in-SSO-NAA-IE/assets/sample.json Outdated Show resolved Hide resolved
Copy link
Collaborator

@AlexJerabek AlexJerabek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making those changes. Approving with one more suggestion.

Samples/auth/Outlook-Add-in-SSO-NAA-IE/assets/sample.json Outdated Show resolved Hide resolved
@codexeon codexeon merged commit 4b58001 into main Oct 1, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants