Collator: add test for joinCollatorPool - #87
Merged
Conversation
rauljordan
approved these changes
Apr 3, 2018
rauljordan
left a comment
rauljordan
left a comment
Contributor
There was a problem hiding this comment.
All of this seems like basic renaming + some func abstraction. Looks good to me and tests pass on my computer.
rauljordan
reviewed
Apr 3, 2018
| } | ||
|
|
||
| func TestJoinCollatorPool(t *testing.T) { | ||
| backend, smc := setup() |
Contributor
There was a problem hiding this comment.
How extensible is this approach to future testing? Do we have to initialize it like the setup like this within each testing method?
Member
Author
There was a problem hiding this comment.
Yeah, I think so. I added a TODO to consider moving this setup to some common testing package since the proposer would likely want the same setup methods and mockClient.
terencechain
self-requested a review
April 3, 2018 03:04
Member
Author
|
Why is Travis so flaky... hmmm. It passes on 1 of 3 so I'd consider that passing :) |
Collaborator
|
Looks good to me, we should refactor the test setup in another PR |
prestonvanloon
added a commit
that referenced
this pull request
Jul 22, 2018
Collator: add test for joinCollatorPool
prestonvanloon
added a commit
that referenced
this pull request
Jul 22, 2018
Collator: add test for joinCollatorPool Former-commit-id: abc8304
Redidacove
pushed a commit
to Redidacove/prysm
that referenced
this pull request
Aug 13, 2024
* updated my development updates for week 1 and week 0 * alphabetical order, table fix --------- Co-authored-by: Mário Havel <61149543+taxmeifyoucan@users.noreply.github.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added test for the basic functionality of joinCollatorPool
Also renamed CreateTXOps to CreateTXOpts to match the
TransactOptstype