Updates pubkey from bytes32 to bytes

[0xKiwi]

Resolves issue #562

---

Changes pubkey from bytes32 to bytes

The changes made modify all the bytes32 to bytes and make sure its checks that it is a 48length byte array.
Also changes pubKey mapping to a hashPubKey mapping due to the changes required.

[terencechain]

Looks good. Please add a test case in validator_registration_test.go

[codecov]

Codecov Report

Merging #630 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master    #630   +/-   ##
======================================
  Coverage    75.9%   75.9%           
======================================
  Files          56      56           
  Lines        3748    3748           
======================================
  Hits         2845    2845           
  Misses        648     648           
  Partials      255     255

[prestonvanloon]

Don't you need to rebuild the go libraries?

[terencechain]

Did you regenerate validator_registration.go or manually changed it [48]byte?

Weird it still says function deposit(_pubkey bytes32,... at the top

[0xKiwi]

Changing the mapping from bytes32 to bytes is actually not possible in Solidity since bytes is a dynamic type. How should we approach this change for Solidity? Maybe use a hash of the bytes array?

[prestonvanloon]

What is wrong with a dynamic type other than being wasteful?

https://solidity.readthedocs.io/en/v0.4.24/types.html#dynamically-sized-byte-array

Can you store the pubkey as two byte32s and concat them?

[0xKiwi]

https://solidity.readthedocs.io/en/v0.4.25/types.html#mappings
Dynamic types can't be used as the key for mappings.
Mapping types are declared as mapping(_KeyType => _ValueType). Here _KeyType can be almost any type except for a mapping, a dynamically sized array, a contract, an enum and a struct. _ValueType can actually be any type, including mappings.

What would I concat them into though? I can't do a string (because dynamic length) or a number (48 bytes > 32 bytes).

[nisdas]

@IvanTheGreatDev Whats the status on this ?

[0xKiwi]

Still the same status. Solidity doesn't allow bytes as a key type for mappings, so the max amount of bytes we can use is 32.

…

On Sat, Oct 20, 2018, 1:31 AM Nishant Das ***@***.***> wrote: @IvanTheGreatDev <https://github.com/IvanTheGreatDev> Whats the status on this ? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#630 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AF9j9is9l3Ae20n_-DqMl5otAJGX4TJEks5umrUfgaJpZM4XMOh1> .

[nisdas]

@terenc3t @prestonvanloon What do you guys think ? Should we just store the hash of the pubkey instead in the mapping ?

[0xKiwi]

Alright, I changed it to just use the hash of the bytes array the user passes in. Good for review now.

[terencechain]

👍

[CLAassistant]

All committers have signed the CLA.