Allow builders to bid on multiple branches - #17237
Closed
terencechain wants to merge 2 commits into
Closed
Conversation
satushh
reviewed
Jul 27, 2026
| } | ||
|
|
||
| func (s *Service) setSeenExecutionPayloadBid(slot primitives.Slot, tupleKey, builderKey string) { | ||
| s.seenExecutionPayloadBidCache.Add(slot, tupleKey, true) |
Member
There was a problem hiding this comment.
Should we update the value of seenExecutionPayloadBidSize ?
james-prysm
reviewed
Jul 28, 2026
| MaxPerEpochActivationChurnLimitGloas: 256_000_000_000, | ||
| MaxBuilderDepositRequestsPerPayload: 256, // 2**8 (= 256) | ||
| MaxBuilderExitRequestsPerPayload: 16, // 2**4 (= 16) | ||
| MaxBidsPerBuilder: 3, |
Contributor
There was a problem hiding this comment.
constant seenExecutionPayloadBidSize = 1000 is still the same, is this churn 4x faster ok? or should we increase that number too?
Collaborator
Author
|
Closing in favor of ethereum/consensus-specs#5497, which was merged as the alternative to the MAX_BIDS_PER_BUILDER approach (#5472). Will open a new PR implementing the head-compatibility check. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spec reference: ethereum/consensus-specs#5472