Skip to content

allowing ptc duties for next epoch on grpc endpoint #16608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
terencechain merged 1 commit into from
Apr 2, 2026
Merged

allowing ptc duties for next epoch on grpc endpoint #16608

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions beacon-chain/rpc/prysm/v1alpha1/validator/duties_v3.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,10 +189,10 @@ func (vs *Server) GetPTCDuties(ctx context.Context, req *ethpb.PTCDutiesRequest)
return nil, status.Errorf(codes.InvalidArgument, "Request epoch %d is before Gloas fork epoch %d", req.Epoch, params.BeaconConfig().GloasForkEpoch)
}

// PTC assignments are not stable for the next epoch, so only allow current epoch.
currentEpoch := slots.ToEpoch(vs.TimeFetcher.CurrentSlot())
if req.Epoch > currentEpoch {
return nil, status.Errorf(codes.InvalidArgument, "Request epoch %d can not be greater than current epoch %d", req.Epoch, currentEpoch)
nextEpoch := currentEpoch.Add(1)
if req.Epoch > nextEpoch {
return nil, status.Errorf(codes.InvalidArgument, "Request epoch %d can not be greater than next epoch %d", req.Epoch, nextEpoch)
}

s, err := vs.HeadFetcher.HeadState(ctx)
Expand Down
4 changes: 2 additions & 2 deletions beacon-chain/rpc/prysm/v1alpha1/validator/duties_v3_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -373,9 +373,9 @@ func TestGetPTCDuties_EpochOutOfBound(t *testing.T) {
SyncChecker: &mockSync.Sync{IsSyncing: false},
}
currentEpoch := primitives.Epoch(chain.CurrentSlot() / params.BeaconConfig().SlotsPerEpoch)
req := &ethpb.PTCDutiesRequest{Epoch: currentEpoch + 1}
req := &ethpb.PTCDutiesRequest{Epoch: currentEpoch + 2}
_, err := vs.GetPTCDuties(t.Context(), req)
assert.ErrorContains(t, "can not be greater than current epoch", err)
assert.ErrorContains(t, "can not be greater than next epoch", err)
}

func TestGetPTCDuties_PreGloasFork(t *testing.T) {
Expand Down
3 changes: 3 additions & 0 deletions changelog/james-prysm_ptc-next-duties-grpc.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
### Changed

- allows ptc duties grpc endpoint to work for next epoch.
Loading