Re-add next-epoch lookahead for PTC duties - #16591
Merged
Merged
Conversation
james-prysm
reviewed
Mar 30, 2026
| if rpcErr != nil { | ||
| return nil, status.Errorf(core.ErrorReasonToGRPC(rpcErr.Reason), "%v", rpcErr.Err) | ||
| } | ||
| nextPTCDuties, rpcErr := vs.CoreService.PTCDuties(ctx, s, req.Epoch+1, requestIndices) |
Contributor
There was a problem hiding this comment.
I realized we can probably use .Add(1) instead of +1 for this and other ones
james-prysm
reviewed
Mar 30, 2026
| cs := s.TimeFetcher.CurrentSlot() | ||
| currentEpoch := slots.ToEpoch(cs) | ||
| if requestedEpoch > currentEpoch { | ||
| nextEpoch := currentEpoch + 1 |
Contributor
There was a problem hiding this comment.
i guess we can do .Add(1) here too
james-prysm
approved these changes
Mar 30, 2026
4 tasks
bharath-123
pushed a commit
to bharath-123/prysm
that referenced
this pull request
Mar 31, 2026
**What type of PR is this?** Feature **What does this PR do? Why is it needed?** Add current and next epoch lookahead as per ethereum/beacon-APIs#592 **Which issues(s) does this PR fix?** Fixes # **Other notes for review** **Acknowledgements** - [ ] I have read [CONTRIBUTING.md](https://github.com/prysmaticlabs/prysm/blob/develop/CONTRIBUTING.md). - [ ] I have included a uniquely named [changelog fragment file](https://github.com/prysmaticlabs/prysm/blob/develop/CONTRIBUTING.md#maintaining-changelogmd). - [ ] I have added a description with sufficient context for reviewers to understand this PR. - [ ] I have tested that my changes work as expected and I added a testing plan to the PR description (if applicable).
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Apr 2, 2026
**What type of PR is this?** Bug fix **What does this PR do? Why is it needed?** adding next epoch fix for grpc endpoint ( currently unused) #16591 **Which issues(s) does this PR fix?** Fixes # **Other notes for review** **Acknowledgements** - [x] I have read [CONTRIBUTING.md](https://github.com/prysmaticlabs/prysm/blob/develop/CONTRIBUTING.md). - [x] I have included a uniquely named [changelog fragment file](https://github.com/prysmaticlabs/prysm/blob/develop/CONTRIBUTING.md#maintaining-changelogmd). - [x] I have added a description with sufficient context for reviewers to understand this PR. - [x] I have tested that my changes work as expected and I added a testing plan to the PR description (if applicable).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature
What does this PR do? Why is it needed?
Add current and next epoch lookahead as per ethereum/beacon-APIs#592
Which issues(s) does this PR fix?
Fixes #
Other notes for review
Acknowledgements