rpc: add SubmitSignedProposerPreferences gRPC endpoint - #16538
Merged
Conversation
terencechain
force-pushed
the
gloas-proposer-preferences-rpc
branch
from
March 15, 2026 20:31
5184c20 to
bb31b88
Compare
This was referenced Mar 16, 2026
4 tasks
terencechain
force-pushed
the
gloas-proposer-preferences-rpc
branch
2 times, most recently
from
March 17, 2026 02:10
3de6898 to
0022770
Compare
Add the validator-facing RPC for broadcasting signed proposer preferences. Validators call this endpoint to submit their preferred fee_recipient and gas_limit for a future proposal slot. The handler validates the request, broadcasts via P2P, and caches the preferences for downstream bid validation. - Proto: SubmitSignedProposerPreferences RPC in validator.proto - RPC: handler with epoch/sync validation and P2P broadcast - Wiring: server, rpc service, and node plumbing
terencechain
force-pushed
the
gloas-proposer-preferences-rpc
branch
from
March 17, 2026 02:12
0022770 to
5e78fde
Compare
james-prysm
reviewed
Mar 17, 2026
| ) | ||
| } | ||
|
|
||
| if vs.ProposerPreferencesCache.Has(proposalSlot) { |
Contributor
There was a problem hiding this comment.
if we already proposed it aka in the cache, should we just be returning empty? what about a debut log here saying some kind of duplicate submission?
james-prysm
reviewed
Mar 17, 2026
| } | ||
|
|
||
| currentEpoch := slots.ToEpoch(vs.TimeFetcher.CurrentSlot()) | ||
| if slots.ToEpoch(proposalSlot) != currentEpoch+1 { |
Contributor
There was a problem hiding this comment.
is the intended use only for the next epoch? if you restart your validator client and it needs to propose in the epoch it restarted on this would fail?
Collaborator
Author
There was a problem hiding this comment.
P2P will ignore it anyway so it's better to know that with an error
[IGNORE] preferences.proposal_slot is in the next epoch -- i.e. compute_epoch_at_slot(preferences.proposal_slot) == get_current_epoch(state) + 1.
Contributor
There was a problem hiding this comment.
will bring up this concern again ethereum/consensus-specs#4777 (comment)
james-prysm
approved these changes
Mar 17, 2026
james-prysm
left a comment
james-prysm
left a comment
Contributor
There was a problem hiding this comment.
approving with a concern on the spec
terencechain
enabled auto-merge
March 17, 2026 15:07
4 tasks
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Mar 19, 2026
**What type of PR is this?** Other **What does this PR do? Why is it needed?** It makes more sense for this endpoint to take an array instead, this was an oversight from review. this is a breaking change but should be acceptable as we havent released yet **Which issues(s) does this PR fix?** Fixes #16538 **Other notes for review** **Acknowledgements** - [x] I have read [CONTRIBUTING.md](https://github.com/prysmaticlabs/prysm/blob/develop/CONTRIBUTING.md). - [x] I have included a uniquely named [changelog fragment file](https://github.com/prysmaticlabs/prysm/blob/develop/CONTRIBUTING.md#maintaining-changelogmd). - [x] I have added a description with sufficient context for reviewers to understand this PR. - [ ] I have tested that my changes work as expected and I added a testing plan to the PR description (if applicable).
syjn99
pushed a commit
to syjn99/prysm
that referenced
this pull request
Mar 27, 2026
…16538) This pr adds the validator-facing gRPC endpoint for submitting signed proposer preferences. Validators call this to broadcast their preferred fee_recipient and gas_limit for a future proposal slot. The handler validates the epoch, broadcasts via P2P, and caches preferences for downstream bid validation. - Proto: `SubmitSignedProposerPreferences` RPC in `validator.proto` - RPC handler with epoch and sync validation, P2P broadcast - Local submissions bypass full gossip verification (trusted VC) > **Note:** This is PR 2 of 3 in a stack. Please review in order: > 1. Proposer preferences P2P > 2. **This PR** — proposer preferences RPC endpoint > 3. Execution payload bid P2P
syjn99
pushed a commit
to syjn99/prysm
that referenced
this pull request
Mar 27, 2026
…s#16554) **What type of PR is this?** Other **What does this PR do? Why is it needed?** It makes more sense for this endpoint to take an array instead, this was an oversight from review. this is a breaking change but should be acceptable as we havent released yet **Which issues(s) does this PR fix?** Fixes OffchainLabs#16538 **Other notes for review** **Acknowledgements** - [x] I have read [CONTRIBUTING.md](https://github.com/prysmaticlabs/prysm/blob/develop/CONTRIBUTING.md). - [x] I have included a uniquely named [changelog fragment file](https://github.com/prysmaticlabs/prysm/blob/develop/CONTRIBUTING.md#maintaining-changelogmd). - [x] I have added a description with sufficient context for reviewers to understand this PR. - [ ] I have tested that my changes work as expected and I added a testing plan to the PR description (if applicable).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr adds the validator-facing gRPC endpoint for submitting signed proposer preferences. Validators call this to broadcast their preferred fee_recipient and gas_limit for a future proposal slot. The handler validates the epoch, broadcasts via P2P, and caches preferences for downstream bid validation.
SubmitSignedProposerPreferencesRPC invalidator.proto