Reorganize duties functions - #16457
Merged
Merged
Conversation
satushh
previously approved these changes
Mar 4, 2026
prestonvanloon
requested changes
Mar 4, 2026
| // UpdateDuties checks the slot number to determine if the validator's | ||
| // list of upcoming assignments needs to be updated. For example, at the | ||
| // beginning of a new epoch. | ||
| func (v *validator) UpdateDuties(ctx context.Context) error { |
Member
There was a problem hiding this comment.
Please move the unit tests for UpdateDuties to duties_test.go
Contributor
Author
There was a problem hiding this comment.
updated thanks for the feedback
prestonvanloon
approved these changes
Mar 4, 2026
syjn99
pushed a commit
to syjn99/prysm
that referenced
this pull request
Mar 13, 2026
**What type of PR is this?** Other **What does this PR do? Why is it needed?** just moving some functions around to reduce duties split pr. part of OffchainLabs#16421 **Which issues(s) does this PR fix?** Fixes # **Other notes for review** **Acknowledgements** - [x] I have read [CONTRIBUTING.md](https://github.com/prysmaticlabs/prysm/blob/develop/CONTRIBUTING.md). - [x] I have included a uniquely named [changelog fragment file](https://github.com/prysmaticlabs/prysm/blob/develop/CONTRIBUTING.md#maintaining-changelogmd). - [x] I have added a description with sufficient context for reviewers to understand this PR. - [x] I have tested that my changes work as expected and I added a testing plan to the PR description (if applicable).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Other
What does this PR do? Why is it needed?
just moving some functions around to reduce duties split pr. part of #16421
Which issues(s) does this PR fix?
Fixes #
Other notes for review
Acknowledgements