Fix proposer to use advanced state for sync committee position calculation#15905
Merged
prestonvanloon merged 2 commits intodevelopfrom Oct 21, 2025
Merged
Fix proposer to use advanced state for sync committee position calculation#15905prestonvanloon merged 2 commits intodevelopfrom
prestonvanloon merged 2 commits intodevelopfrom
Conversation
potuz
reviewed
Oct 21, 2025
Contributor
potuz
left a comment
potuz
left a comment
There was a problem hiding this comment.
LGTM, is it possible to add a regression test, trying to set the head at the pre-epoch and checking that the sync committee will be the wrong one?
Contributor
|
It makes sense to me, thanks for finding this |
james-prysm
previously approved these changes
Oct 21, 2025
prestonvanloon
approved these changes
Oct 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bug in #15608
At sync committee boundary we see:
Instead of using head state, I think it should use head state advanced to the proposal slot