Get blob fulu #15610
Merged
Get blob fulu #15610
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-prysm
commented
Sep 16, 2025
| } | ||
|
|
||
| // If block is not in the retention window, return 200 w/ empty list | ||
| if !p.BlobStorage.WithinRetentionPeriod(slots.ToEpoch(roSignedBlock.Block().Slot()), slots.ToEpoch(p.GenesisTimeFetcher.CurrentSlot())) { |
Contributor
Author
There was a problem hiding this comment.
I'm removing this check based on discussion with manu, we should just return what we have
rkapka
reviewed
Sep 17, 2025
| field_params "github.com/OffchainLabs/prysm/v6/config/fieldparams" | ||
| "github.com/OffchainLabs/prysm/v6/beacon-chain/rpc/eth/shared" | ||
| "github.com/OffchainLabs/prysm/v6/beacon-chain/rpc/options" | ||
| fieldparams "github.com/OffchainLabs/prysm/v6/config/fieldparams" |
Contributor
There was a problem hiding this comment.
the alias can be removed because it is identical to the package name
Contributor
Author
There was a problem hiding this comment.
oops not sure how that happened
Contributor
Author
There was a problem hiding this comment.
wait it's called field_params so i need to leave it or use the old one
i think field_params is not preferred
rkapka
reviewed
Sep 17, 2025
beacon-chain/rpc/lookup/blocker.go
Outdated
|
|
||
| // Verify all requested hashes were found | ||
| if len(indices) != len(cfg.VersionedHashes) { | ||
| return nil, &core.RpcError{Err: errors.New("versioned hash does not exist in given block"), Reason: core.NotFound} |
Contributor
There was a problem hiding this comment.
This would require writing some more code, but it would be nice to let the caller know exactly which hash(es) were not found
Co-authored-by: Radosław Kapka <[email protected]>
Co-authored-by: Radosław Kapka <[email protected]>
rkapka
reviewed
Sep 17, 2025
Co-authored-by: Radosław Kapka <[email protected]>
rkapka
approved these changes
Sep 17, 2025
3 tasks
fernantho
pushed a commit
to fernantho/prysm
that referenced
this pull request
Sep 26, 2025
* wip * wip * adding ssz marshalling * updating function for readability * adding unit tests and fixing ssz * gaz * linting * fixing test * wip * fixing mock blocker * fixing test * fixing tests and handler * updating unit test for more coverage * adding some comments * self review * gofmt * updating and consolidating tests * moving functional options so it can be used properly * gofmt * more missed gofmt * Update beacon-chain/rpc/endpoints.go Co-authored-by: Radosław Kapka <[email protected]> * Update beacon-chain/rpc/lookup/blocker.go Co-authored-by: Radosław Kapka <[email protected]> * Update beacon-chain/rpc/eth/beacon/handlers.go Co-authored-by: Radosław Kapka <[email protected]> * radek feedback * fixing tests * fixing test * moving endpoint in test * removed unneeded comment * fixing linting from latest develop merge * fixing linting from latest develop merge * Update beacon-chain/rpc/eth/blob/handlers.go Co-authored-by: Radosław Kapka <[email protected]> * Update beacon-chain/rpc/eth/blob/handlers.go Co-authored-by: Radosław Kapka <[email protected]> * reverting change * reverting change * adding in better error for which hashes are missing * Update beacon-chain/rpc/lookup/blocker.go Co-authored-by: Radosław Kapka <[email protected]> * fixing unit test * gofmt --------- Co-authored-by: Radosław Kapka <[email protected]>
fernantho
pushed a commit
to fernantho/prysm
that referenced
this pull request
Sep 26, 2025
* wip * wip * adding ssz marshalling * updating function for readability * adding unit tests and fixing ssz * gaz * linting * fixing test * wip * fixing mock blocker * fixing test * fixing tests and handler * updating unit test for more coverage * adding some comments * self review * gofmt * updating and consolidating tests * moving functional options so it can be used properly * gofmt * more missed gofmt * Update beacon-chain/rpc/endpoints.go Co-authored-by: Radosław Kapka <[email protected]> * Update beacon-chain/rpc/lookup/blocker.go Co-authored-by: Radosław Kapka <[email protected]> * Update beacon-chain/rpc/eth/beacon/handlers.go Co-authored-by: Radosław Kapka <[email protected]> * radek feedback * fixing tests * fixing test * moving endpoint in test * removed unneeded comment * fixing linting from latest develop merge * fixing linting from latest develop merge * Update beacon-chain/rpc/eth/blob/handlers.go Co-authored-by: Radosław Kapka <[email protected]> * Update beacon-chain/rpc/eth/blob/handlers.go Co-authored-by: Radosław Kapka <[email protected]> * reverting change * reverting change * adding in better error for which hashes are missing * Update beacon-chain/rpc/lookup/blocker.go Co-authored-by: Radosław Kapka <[email protected]> * fixing unit test * gofmt --------- Co-authored-by: Radosław Kapka <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature
What does this PR do? Why is it needed?
adds the new endpoint /eth/v1/beacon/blobs/{block_id} that will later replace /eth/v1/beacon/blob_sidecars/{block_id}
Which issues(s) does this PR fix?
Fixes # ethereum/beacon-APIs#546
task in #14129
Other notes for review
Acknowledgements