Update consensus spec to v1.6.0-alpha.4 and implement data column support#15590
Merged
terencechain merged 2 commits intodevelopfrom Aug 16, 2025
Merged
Update consensus spec to v1.6.0-alpha.4 and implement data column support#15590terencechain merged 2 commits intodevelopfrom
terencechain merged 2 commits intodevelopfrom
Conversation
…port for forkchoice spectests
terencechain
force-pushed
the
v1.6.0-alpha4-spec-tests
branch
from
d12eda8 to
8bbb5cd
Compare
| columnFiles = append(columnFiles, step.DataColumns...) | ||
| } | ||
| if len(columnFiles) == 0 { | ||
| return |
Member
There was a problem hiding this comment.
Are there cases where there are not files? Could this be a false positive if the test runs on an empty directory but there were files expected? Perhaps this should fail here
Collaborator
Author
There was a problem hiding this comment.
Ya good point, will change it to fail
Co-Authored-By: Preston Van Loon <pvanloon@offchainlabs.com>
terencechain
force-pushed
the
v1.6.0-alpha4-spec-tests
branch
from
ed913c5 to
764d8d4
Compare
james-prysm
reviewed
Aug 14, 2025
| } | ||
| } | ||
|
|
||
| if err := dv.NotFromFutureSlot(); err != nil { |
Contributor
There was a problem hiding this comment.
i think maybe i'm not familiar with the design, but maybe on the verifier we can have a function that returns the verification function based on the verification value instead of manually adding them below?
Collaborator
Author
There was a problem hiding this comment.
i think that's a good idea, ill do it in another pr 🫡
james-prysm
reviewed
Aug 14, 2025
| if !*step.Valid { | ||
| return func(t *testing.T, err error) { | ||
| require.ErrorIs(t, err, expect) | ||
| if expect.Error() == "data columns failed verification" { |
Contributor
There was a problem hiding this comment.
this seems potentially fragile, we should have a named variables if it's suppose to be be special I think
Contributor
There was a problem hiding this comment.
you added one on line 322 i guess
3 tasks
prestonvanloon
approved these changes
Aug 15, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
jihoonsong
pushed a commit
to jihoonsong/prysm
that referenced
this pull request
Aug 27, 2025
…port (OffchainLabs#15590) * Update consensus spec to v1.6.0-alpha.4 and implement data column support for forkchoice spectests * Apply suggestion from @prestonvanloon Co-Authored-By: Preston Van Loon <pvanloon@offchainlabs.com> --------- Co-authored-by: Preston Van Loon <pvanloon@offchainlabs.com>
fernantho
pushed a commit
to fernantho/prysm
that referenced
this pull request
Sep 26, 2025
…port (OffchainLabs#15590) * Update consensus spec to v1.6.0-alpha.4 and implement data column support for forkchoice spectests * Apply suggestion from @prestonvanloon Co-Authored-By: Preston Van Loon <pvanloon@offchainlabs.com> --------- Co-authored-by: Preston Van Loon <pvanloon@offchainlabs.com>
fernantho
pushed a commit
to fernantho/prysm
that referenced
this pull request
Sep 26, 2025
…port (OffchainLabs#15590) * Update consensus spec to v1.6.0-alpha.4 and implement data column support for forkchoice spectests * Apply suggestion from @prestonvanloon Co-Authored-By: Preston Van Loon <pvanloon@offchainlabs.com> --------- Co-authored-by: Preston Van Loon <pvanloon@offchainlabs.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v1.6.0-alpha.1tov1.6.0-alpha.4SpectestDataColumnSidecarRequirementsfor forkchoice spectest data column verificationrunDataColumnStep()function to handle data column sidecar processing