wrapping goodbye messages in goroutine to speed up node shutdown #15542
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-prysm
added
networking
optimization
nalepae
approved these changes
Jul 31, 2025
Muzry
pushed a commit
to Muzry/prysm
that referenced
this pull request
Aug 10, 2025
…chainLabs#15542) * wrapping goodbye messages in goroutine to speed up node shutdown * fixing requirement
fernantho
pushed a commit
to fernantho/prysm
that referenced
this pull request
Sep 26, 2025
…chainLabs#15542) * wrapping goodbye messages in goroutine to speed up node shutdown * fixing requirement
fernantho
pushed a commit
to fernantho/prysm
that referenced
this pull request
Sep 26, 2025
…chainLabs#15542) * wrapping goodbye messages in goroutine to speed up node shutdown * fixing requirement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Other
What does this PR do? Why is it needed?
goodbye messages on the sync service are currently in sequence. we should parallelize this so if you have many peers it and you shutdown you are not waiting for all the goodbyes one at a time resulting in potentially not sending goodbyes to other peers and getting penalized for it.
Which issues(s) does this PR fix?
part of #14129
Other notes for review
Acknowledgements