Peerdas various #15423
Merged
Peerdas various #15423
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nalepae
force-pushed
the
peerdas-columns-by-range
branch
from
97a599d to
3b459fd
Compare
nalepae
force-pushed
the
peerdas-various
branch
3 times, most recently
from
c1afe3e to
a09a325
Compare
nalepae
force-pushed
the
peerdas-columns-by-range
branch
from
760acff to
b9346b1
Compare
james-prysm
reviewed
Jun 20, 2025
james-prysm
reviewed
Jun 20, 2025
| // Not modified in altair fork. | ||
| topic, err := TopicFromMessage(GoodbyeMessageName, altairForkEpoch) | ||
| require.NoError(t, err) | ||
| require.Equal(t, "/eth2/beacon_chain/req/goodbye/1", topic) |
Contributor
There was a problem hiding this comment.
it should be some kind of constant + something dynamic right?
Contributor
Author
There was a problem hiding this comment.
There is only one version of the goodbye message.
So, for goodbye message it is always /eth2/beacon_chain/req/goodbye/1.
Cosmetic change, no functional change.
`DataColumnIdentifier` was removed in the spec here: ethereum/consensus-specs#4284. Eventually, we stopped using it in Prysm, but never removed the corresponding proto message. The new `StatusV2` is introduced in the spec here: ethereum/consensus-specs#4374
Merged
3 tasks
james-prysm
approved these changes
Jun 23, 2025
fernantho
pushed a commit
to fernantho/prysm
that referenced
this pull request
Sep 26, 2025
* Topic mapping: Groupe `const` and `var`. Cosmetic change, no functional change. * `TopicFromMessage`: Do not assume anymore that all Fulu specific topics are V3 only. * Proto: Remove unused `DataColumnIdentifier` and add new `StatusV2`. `DataColumnIdentifier` was removed in the spec here: ethereum/consensus-specs#4284. Eventually, we stopped using it in Prysm, but never removed the corresponding proto message. The new `StatusV2` is introduced in the spec here: ethereum/consensus-specs#4374 * `readChunkedDataColumnSideCar` ==> `readChunkedDataColumnSidecar`. * `rpc_send_request.go`: Reorganize file (no function change). * `readChunkedDataColumnSidecar`: Add `validationFunctions` parameter and add tests.
fernantho
pushed a commit
to fernantho/prysm
that referenced
this pull request
Sep 26, 2025
* Topic mapping: Groupe `const` and `var`. Cosmetic change, no functional change. * `TopicFromMessage`: Do not assume anymore that all Fulu specific topics are V3 only. * Proto: Remove unused `DataColumnIdentifier` and add new `StatusV2`. `DataColumnIdentifier` was removed in the spec here: ethereum/consensus-specs#4284. Eventually, we stopped using it in Prysm, but never removed the corresponding proto message. The new `StatusV2` is introduced in the spec here: ethereum/consensus-specs#4374 * `readChunkedDataColumnSideCar` ==> `readChunkedDataColumnSidecar`. * `rpc_send_request.go`: Reorganize file (no function change). * `readChunkedDataColumnSidecar`: Add `validationFunctions` parameter and add tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Other
What does this PR do? Why is it needed?
This PR:
constandvarin the same section.TopicFromMessage: Does not assume anymore that all Fulu specific topic are V3 only. (It is currently the case, but not in the future any more.)DataColumnIdentifierand add newStatusV2.readChunkedDataColumnSidecar: AddvalidationFunctionsparameter and add tests.Other notes for review
Please read commit by commit, with commit messages.
Dependent on:
Acknowledgements