Skip to content

Deprecate pb.gw.go files#14464

Merged
james-prysm merged 2 commits intoOffchainLabs:developfrom
syjn99:chore/clean-gw-files
Sep 20, 2024
Merged

Deprecate pb.gw.go files#14464
james-prysm merged 2 commits intoOffchainLabs:developfrom
syjn99:chore/clean-gw-files

Conversation

@syjn99
Copy link
Contributor

@syjn99 syjn99 commented Sep 20, 2024

What type of PR is this?

Other

What does this PR do? Why is it needed?

Farewell to gateway files

#14089 deprecates *pb.gw.go files, but there are some dregs around *pb.gw.go file supports. This PR fully deprecates those supports, which will help newcomers investigate this project.

Acknowledgements

  • I have read CONTRIBUTING.md.
  • I have made an appropriate entry to CHANGELOG.md.
  • I have added a description to this PR with sufficient context for reviewers to understand this PR.

@syjn99 syjn99 requested a review from a team as a code owner September 20, 2024 09:15
@syjn99 syjn99 changed the title Depreacte pb.gw.go files Deprecate pb.gw.go files Sep 20, 2024
@james-prysm
Copy link
Contributor

good catch on this thanks

Copy link
Member

@prestonvanloon prestonvanloon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, thanks

@james-prysm james-prysm added this pull request to the merge queue Sep 20, 2024
Merged via the queue into OffchainLabs:develop with commit 1a1cc25 Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants